fix(Boost for reddit - Fix missing audio in video downloads): Replace correct strings #3379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alid string replacement
OctoNezd
force-pushed
the
fix-fix-audio-download
branch
from
ae0fe85
to
3cc16f3
Compare
oSumAtrIX
changed the title
oSumAtrIX
reviewed
Jun 24, 2024
...patches/reddit/customclients/boostforreddit/fix/downloads/FixAudioMissingInDownloadsPatch.kt
Show resolved
Hide resolved
revanced-bot
pushed a commit
that referenced
this pull request
Jun 24, 2024
## [4.10.1-dev.2](v4.10.1-dev.1...v4.10.1-dev.2) (2024-06-24) ### Bug Fixes * **Boost for reddit - Fix missing audio in video downloads:** Replace correct strings ([#3379](#3379)) ([b43db98](b43db98))
|
I tested it using the 4.11.0-dev2 patches which afaik should have the fix and it still doesn't work for me |
|
Tested patch with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some refactor broke the audio download feature, resulting in
v.redd.itand/strings getting replaced instead of audio endpoints resulting in client not even trying to download audio. This fixes that, by removing these two strings and keeping only/DASH_audio.mp4and/audio. Both strings are unique in final version of Boost.