Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: teaser comment UI updated by Google (litho component change) #982

Open
3 tasks done
0xrxL opened this issue May 13, 2023 · 14 comments
Open
3 tasks done

bug: teaser comment UI updated by Google (litho component change) #982

0xrxL opened this issue May 13, 2023 · 14 comments
Labels
Bug report Something isn't working

Comments

@0xrxL
Copy link

0xrxL commented May 13, 2023

Type

Cosmetic

Bug description

Google merged Live Chat together with comments box, on latest YouTube versions. Therefore removing all components marked as "|carousel_item" results in the inability of open the Live Chat.

Steps to reproduce

Open this video and, if this new feature will be enabled for your account, you'll be able to see this new comments box with up-right dots.

Relevant log output

Not needed

Screenshots or videos

Screenshot_20230513_082405

Solution

Replace the litho component name:

  • "|carousel_item"

with:

  • "comment_teaser_carousel_item"

inside the integration file CommentsPatch.java for the field previewComment

Additional context

No response

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
@0xrxL 0xrxL added the Bug report Something isn't working label May 13, 2023
@0xrxL 0xrxL changed the title bug: teaser comment UI updated by Google bug: teaser comment UI updated by Google (litho component change) May 13, 2023
@johnconner122
Copy link
Contributor

This happens:

Screenshot_2023-05-13-18-38-08-337_app.revanced.android.youtube.jpg

@0xrxL
Copy link
Author

0xrxL commented May 13, 2023

This happens:

Screenshot_2023-05-13-18-38-08-337_app.revanced.android.youtube.jpg

This doesn't seems to be a video with Live Chat.

In any case the new Live Chat position should be an A/B testing feature, which needs of the big blank space on your screenshot to show this:

Screenshot_20230513_173629

@oSumAtrIX
Copy link
Member

needs of that big blank space on you your screenshot to perform the

Please reword your sentence, it is not possible to understand you.

@0xrxL
Copy link
Author

0xrxL commented May 13, 2023

needs of that big blank space on you your screenshot to perform the

Please reword your sentence, it is not possible to understand you.

Fixed

@oSumAtrIX
Copy link
Member

which needs of the big blank space

I can still unfortunately not understand you. Your sentence is unclear to me due to grammatic.

@johnconner122
Copy link
Contributor

This doesn't seems to be a video with Live Chat.

In any case the new Live Chat position should be an A/B testing feature, which needs of the big blank space on your screenshot to show this:

Live chat is working, but there is still blank space.

Screenshot_2023-05-13-20-46-31-631_app.revanced.android.youtube.jpg

@0xrxL
Copy link
Author

0xrxL commented May 13, 2023

which needs of the big blank space

I can still unfortunately not understand you. Your sentence is unclear to me due to grammatic.

In few words: the big empty space of those rectangle is needed to perform a swipe from left to right and open live chat.

Without the empty space, the swipe gesture will not work.

@0xrxL
Copy link
Author

0xrxL commented May 13, 2023

This doesn't seems to be a video with Live Chat.
In any case the new Live Chat position should be an A/B testing feature, which needs of the big blank space on your screenshot to show this:

Live chat is working, but there is still blank space.

Screenshot_2023-05-13-20-46-31-631_app.revanced.android.youtube.jpg

Try to perform a swipe on the comment box with original component name "|carousel_item" and after with "comment_teaser_carousel_item".

You will notice the difference (the inability to show Live Chat).

@oSumAtrIX
Copy link
Member

image
Can you swipe here.

@0xrxL
Copy link
Author

0xrxL commented May 13, 2023

image Can you swipe here.

Yeah, but only when bottom empty space is visible.

@oSumAtrIX
Copy link
Member

In that case an option should be added to hide the bottom empty space in addition.

@0xrxL
Copy link
Author

0xrxL commented May 13, 2023

In that case an option should be added to hide the bottom empty space in addition.

Whops...my bad.

Nope, in truth I cannot swipe from that portion. For me it's possible only from empty space.

@0xrxL
Copy link
Author

0xrxL commented May 13, 2023

Screen_Recording_20230513_181006_1.mp4

@oSumAtrIX
Copy link
Member

In that case, an option should still be added that can remove that space; it's annoying and the only use case if you hide the preview comment is to see live chats, which for most people won't be useful.

@oSumAtrIX oSumAtrIX transferred this issue from ReVanced/revanced-patches-template Dec 14, 2023
@oSumAtrIX oSumAtrIX transferred this issue from another repository Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants