Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failed to compile #334

Merged
merged 10 commits into from
May 4, 2022
Merged

Fix failed to compile #334

merged 10 commits into from
May 4, 2022

Conversation

ggdaltoso
Copy link
Member

Steps to reproduce:

  1. clone the repo in your machine
  2. build the packages and make them able to install locally
yarn lerna run build --stream --scope=@react95/{core,icons,clippy} && yarn lerna run prepublishOnly
  1. Open a terminal and create a CRA in the same level as React95 was cloned
npx create-react-app my-app --template file:React95/packages/cra-template
  1. run your project
npm start

closes #331

@ggdaltoso ggdaltoso added the help wanted Extra attention is needed label Apr 27, 2022
@codesandbox-ci
Copy link

codesandbox-ci bot commented May 4, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit fe73253:

Sandbox Source
Vanilla Configuration

@allyssonsantos
Copy link
Member

Hi @ggdaltoso!

I tried to make it work with a fresh CRA application (without using the template), and, when I tried to install @react/core with npm it throwed me an error due peerDependencies versions, so, I've fixed it. This also make the template back working again

@allyssonsantos allyssonsantos marked this pull request as ready for review May 4, 2022 13:06
@ggdaltoso ggdaltoso merged commit 0d0a3a3 into master May 4, 2022
@ggdaltoso ggdaltoso deleted the fix/failed-to-compile branch May 4, 2022 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to compile due to file React95 dependency
2 participants