Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#58 set up eslint #73

Merged
merged 2 commits into from Mar 11, 2019
Merged

#58 set up eslint #73

merged 2 commits into from Mar 11, 2019

Conversation

gennymcdonagh
Copy link
Contributor

Eslint found 208 problems, so will start cleaning those up in a separate PR :)

@ggdaltoso
Copy link
Member

ggdaltoso commented Mar 11, 2019 •
edited

Thank you @gennymcdonagh !

If I could make you a suggestion, use npm run commit for your changes. We've add commitizen and semantic-release in #71

You do not need to change those commit messages but, it will be good in the next.

Also, this PR closes #58

@ggdaltoso ggdaltoso merged commit 8157021 into React95:master Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggdaltoso ggdaltoso ggdaltoso approved these changes

@allyssonsantos allyssonsantos allyssonsantos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gennymcdonagh @ggdaltoso @allyssonsantos