Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 18: Tooltips still not hiding #769

Closed
ansgarsteinkamp opened this issue May 5, 2022 · 35 comments
Closed

React 18: Tooltips still not hiding #769

ansgarsteinkamp opened this issue May 5, 2022 · 35 comments
Assignees

Comments

@ansgarsteinkamp
Copy link

ansgarsteinkamp commented May 5, 2022

With npm's latest version of react-tooltip (version 4.2.21) tooltips still don't hide.

@ansgarsteinkamp ansgarsteinkamp changed the title React 18: Tooltips still not hiding and delayShow with no effect React 18: Tooltips still not hiding and delayShow with no effect (latest npm-version 4.2.21) May 5, 2022
@ansgarsteinkamp ansgarsteinkamp changed the title React 18: Tooltips still not hiding and delayShow with no effect (latest npm-version 4.2.21) React 18: Tooltips still not hiding and delayShow with no effect (4.2.21) May 5, 2022
@ansgarsteinkamp ansgarsteinkamp changed the title React 18: Tooltips still not hiding and delayShow with no effect (4.2.21) React 18: Tooltips still not hiding May 5, 2022
@svmszcck
Copy link

svmszcck commented May 5, 2022

As a quick fix you can do this until the package is updated:

const [tooltip, showTooltip] = useState(true);

<>
 {tooltip && <ReactTooltip effect="solid" />}
 <p
   data-tip="hello world"
   onMouseEnter={() => showTooltip(true)}
   onMouseLeave={() => {
     showTooltip(false);
     setTimeout(() => showTooltip(true), 50);
   }}
 />
</>

@ansgarsteinkamp
Copy link
Author

Thank you very much for the quick fix!
Hoping for a package-update, though, since there are hundreds of tooltips in my project.

@aronhelser
Copy link
Collaborator

Is there a PR that fixes this issue? Can this quick fix be turned into a PR?

@ansgarsteinkamp
Copy link
Author

Correct me if I'm wrong, but commit 064249c solved the React 18 problem, didn't it?
It's just not part of the npm-package 4.2.21.
The quick fix of svmszcck is really just a quick fix. Not very quick in my case, though.

@Roundaround
Copy link

The last tag (and therefore npm release) was almost a year ago... @aronhelser do you have the permissions to push tags and make a new npm release?

@PanRagon
Copy link
Contributor

Seconded on an NPM-update, there's been a lot of bug-fixes over the past year that should be deployed for them to have any value.

@aronhelser
Copy link
Collaborator

npm was supposed to be automated, and I no longer remember how to do it. If I get a chance I'll look into it...

@Kaishley
Copy link

Any luck with the NPM update?

@lalit-sh
Copy link

lalit-sh commented Jun 2, 2022

This seems to be an issue with the new Strict mode of React. I was having the same issue even in production but it worked fine after I removed Strict Mode from my app. As a temporary solution until new update rolls out for the package on NPM

@ansgarsteinkamp
Copy link
Author

@aronhelser Another month has passed, no update on NPM. Is there really nobody who can update the NPM-package based on the fixed issues of the past 12 months? The project is stone-dead, isn't it?

@aronhelser
Copy link
Collaborator

Neither of the maintainers are currently working with React. I've been working exclusively in C++ for the past year. I would be happy to give maintainer access to someone willing to work on the project.

@alexgurr
Copy link
Contributor

@aronhelser I'd be happy to try and help as an active maintainer (with the spare time I can find for it). Been using this library for quite some time.

@aronhelser
Copy link
Collaborator

@wwayne if we'd like to add @alexgurr as a maintainer, I think you would need to do it. WDYT?

@Kaishley
Copy link

@wwayne kind reminder

@d4mr
Copy link

d4mr commented Aug 1, 2022

@wwayne gentle nudge

@pdeszynski
Copy link
Contributor

pdeszynski commented Aug 3, 2022

npm was supposed to be automated, and I no longer remember how to do it. If I get a chance I'll look into it...

@aronhelser yarn run semantic-release --publish --ci false ?

@present-g
Copy link

present-g commented Aug 4, 2022

Hello everybody! What is known about the update?

@poeck
Copy link

poeck commented Aug 24, 2022

@roggervalf is this something you could do?

@sundarrajendran
Copy link

Do we have any solution for that? I am experiencing the same issue in production.

@pdeszynski
Copy link
Contributor

@sundarrajendran temporarily, until issue is resolved here, you can replace it with a fork of mine https://www.npmjs.com/package/react-tooltip-rc

@aronhelser
Copy link
Collaborator

@pdeszynski I would like to point to your package as a maintained version of this package in the readme - is this OK with you? Are you able to help with maintaining the project? I am probably going to mark this project as archived/inactive.

@aronhelser
Copy link
Collaborator

@alexgurr I know you were interested in possibly being maintainer. Maybe you can coordinate with @pdeszynski ?

@pdeszynski
Copy link
Contributor

@pdeszynski I would like to point to your package as a maintained version of this package in the readme - is this OK with you? Are you able to help with maintaining the project? I am probably going to mark this project as archived/inactive.

@aronhelser I don't mind, though if you would like to point to a GH repository - then i would suggest to use https://github.com/react-tooltip/react-tooltip so that does not change anymore no matter who the maintainer will be.

@elionntechguy
Copy link

elionntechguy commented Oct 3, 2022

hey @pdeszynski i'm trying to install your library but it's not working.
i'm installing it correctly but in node_modules/react-tooltip-rc/dist there's a tar.gz file instead of index.js.
i'm currently using normal react-tooltip, but i'm having the problem when the tooltip is not closing on mouse leave, so i'm hoping your fork fixes this.

@pdeszynski
Copy link
Contributor

pdeszynski commented Oct 3, 2022

@elionntechguy sorry for that 😞 I was playing with github actions to setup builds and I didn't think anyone really uses it yet. Released fixed version with files inside and from now on I promise it will be stable

Zrzut ekranu 2022-10-3 o 08 00 35

@elionntechguy
Copy link

@pdeszynski thanks, but i'm still having the problem of the tooltip not closing when you go off it with clickable=true property. Would you be able to help me?

@elionntechguy
Copy link

@elionntechguy sorry for that 😞 I was playing with github actions to setup builds and I didn't think anyone really uses it yet. Released fixed version with files inside and from now on I promise it will be stable

Zrzut ekranu 2022-10-3 o 08 00 35

@pdeszynski thanks, but i'm still having the problem of the tooltip not closing when you go off it with clickable=true property. Would you be able to help me?

pinging again @pdeszynski

@chiratnachakraborty-betterhalf

Is the issue fixed now...part of npm-package 4.2.21?

@pdeszynski
Copy link
Contributor

@pdeszynski thanks, but i'm still having the problem of the tooltip not closing when you go off it with clickable=true property. Would you be able to help me?

Please open an issue, though I was not able to reproduce that problem https://pdeszynski.github.io/react-tooltip/?path=/story/example-advanced-features--all-props&args=effect:solid;clickable:true

@DarioLopes
Copy link

Yep, still having the issue, setting "strict mode" to false on Next.js seems to do the trick, but is a bit awkward!

Hope it gets fixed soon, anyway, thanks for the work!

@stuarthallows
Copy link

I created a tooltip component using Floating UI (that works fine with React 18). It turns out that once you know how to use Floating UI it's pretty simple to create your own highly customizable tooltip, and you don't actually need react-tooltip any more.
image

@danielbarion
Copy link
Member

Hi guys, we've released a new version that supports React 18 (with the strict mode), I'll close that issue, please try the latest version.

If needs anything else, please let us know, thanks!

@skident
Copy link

skident commented Dec 15, 2023

Hey guys, I just migrated to React 18 and seems like experiencing almost the same issue described here. The minor difference is that my tooltip is not hiding only when I apply a custom style on it. Otherwise it works fine, any ideas on that?

@gabrieljablonski
Copy link
Member

gabrieljablonski commented Dec 15, 2023

@skident are you using V4 or V5? If on V4, please see if it's possible to upgrade to V5, since we're not maintaining V4 any longer.

If on V5, please check this section on the troubleshooting page, or open a new issue with more details.

@skident
Copy link

skident commented Dec 21, 2023

@gabrieljablonski, yes I am using V5 and thanks for the troubleshooting page, the problem was with the opacity property.

@ReactTooltip ReactTooltip locked as off-topic and limited conversation to collaborators Dec 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests