Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: to build using rollup #35

Closed
wants to merge 1 commit into from
Closed

refactor: to build using rollup #35

wants to merge 1 commit into from

Conversation

tdeekens
Copy link

This is a suggestion on how bundling with rollup would work and how it might ease things a little.

  1. Updates .gitignore to contain more sane defaults
  2. Adds rollup as a build tool and a rollup.config.js
  3. Updates npm run-scripts to reflect rollup
  4. Cleans up the tools to not contain the build.js anymore
  5. Adds module and main entries to package.json
  6. Adds run-p so that all builds with targets run in isolation and parallel

I added an output plugin to rollup as this project also seemed to have that before. It will look like this:

screen shot 2017-07-30 at 11 25 29

Closes #34

@tdeekens
Copy link
Author

Is there any chance this could land in the main code base or should I close this PR?

@tdeekens tdeekens closed this Aug 31, 2017
@mjackson
Copy link
Member

This is definitely on my TODO list, just hadn't taken a look yet!

In any case, we'll probably do the exact same build script and configuration we're using in React Router, just to keep things consistent between projects. But thank you for the PR!

mjackson added a commit that referenced this pull request Sep 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants