Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exactly or exact #4237

Closed
pshrmn opened this issue Dec 1, 2016 · 4 comments
Closed

Exactly or exact #4237

pshrmn opened this issue Dec 1, 2016 · 4 comments
Labels
Milestone

Comments

@pshrmn
Copy link
Contributor

pshrmn commented Dec 1, 2016

<Match> uses the exactly prop while <MatchRoutes> routes have an exact property. This should be consistent. I prefer exactly if for no other reason than that <Match> came first.

@timdorr timdorr added the bug label Dec 1, 2016
@timdorr timdorr added this to the v4.0.0 milestone Dec 1, 2016
@timdorr
Copy link
Member

timdorr commented Dec 1, 2016

Marking this as a "bug" in the sense that it's a bug of the API surface.

@sikanhe
Copy link

sikanhe commented Dec 8, 2016

+1 for exact, not many var names uses '*ly' in my experience

@mark0978
Copy link

However <Match exactly pattern='whatever'...> reads better than <Match exact pattern='whatever'...>
But only by a tiny bit.

@mjackson
Copy link
Member

It's too early to nit-pick prop names in v4. We're just exploring some new possible API. Please rest assured we won't ship the final release with two props that are supposed to do the same thing but with different names :)

@lock lock bot locked as resolved and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants