Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ES module build to es/ #3295

Merged
merged 1 commit into from
Apr 13, 2016
Merged

Conversation

taion
Copy link
Contributor

@taion taion commented Apr 13, 2016

This makes us consistent with Redux

This makes us consistent with Redux
@taion taion mentioned this pull request Apr 13, 2016
@timdorr
Copy link
Member

timdorr commented Apr 13, 2016

Let's make a note of this in the Changelog so that those living on the edge and building via these files know to update.

@timdorr timdorr merged commit d4f8d3c into remix-run:master Apr 13, 2016
@taion taion deleted the es-module-build branch April 13, 2016 21:15
@ryanflorence
Copy link
Member

ryanflorence commented Apr 14, 2016

isn't moving the directory of the lib's location a breaking change?

@ryanflorence
Copy link
Member

oh, nvm, main solves it.

@taion
Copy link
Contributor Author

taion commented Apr 14, 2016

jsnext:main, but yeah – the idea is that users should be importing this as 'react-router' anyway, not reaching into es/ manually.

taion added a commit that referenced this pull request Apr 16, 2016
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants