Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass transition hook's arguments correctly #4123

Merged
merged 1 commit into from Nov 1, 2016
Merged

Conversation

arkist
Copy link
Contributor

@arkist arkist commented Oct 31, 2016

I've reported #4114 but nobody responded.
eventually, I fixed it myself. 馃槀

Hope you guys are happy with this. 馃檹

@arkist arkist closed this Oct 31, 2016
@arkist arkist reopened this Oct 31, 2016
@timdorr timdorr changed the title v3 - fix: Passing transition hook's arguments correctly Pass transition hook's arguments correctly Oct 31, 2016
@timdorr timdorr added this to the v3.0.0 milestone Oct 31, 2016
Copy link
Member

@timdorr timdorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind adding a test to ensure we don't regress this fix later on?

@arkist
Copy link
Contributor Author

arkist commented Nov 1, 2016

@timdorr Thanks for respond!
I Added simple test case and updated code.

close and reopen issue for trigger ci build.
it's failing on (ie|mobile safari) sometimes but not because of my change. weird. 馃

@timdorr
Copy link
Member

timdorr commented Nov 1, 2016

I believe because you're the author of the PR, you should see a restart build button in Travis. So, you shouldn't have to close/re-open the PR to trigger a build. It should also pick up on force pushes. You don't have to rebase either, as my usual thing is to squash and merge, so any extraneous commits get cleaned up anyways.

@timdorr timdorr merged commit 70a4272 into remix-run:master Nov 1, 2016
@arkist
Copy link
Contributor Author

arkist commented Nov 3, 2016

@timdorr Thank you for explaining. I will try in next time. 馃槃
do you have any release plan for this?

@cyanic-webdesign
Copy link

This is breaking my unit test which was working in 2.8. So 馃憤 for releasing this. Could probably be a patch release since this is a fixed bug.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants