[v3] Access <Link>s underlying node via innerRef
#6340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalduez
force-pushed
the
feature/v3/link-inner-ref
branch
from
dbf6605
to
e43036d
Compare
pascalduez
changed the title
innerRefinnerRef
|
LGTM. Thanks! |
|
@timdorr Thanks, would you have an eta for a release? :) |
|
No idea. Nothing is planned for 3.0 currently. |
|
+1 for releasing this as a patch for us poor souls still stuck with version 3. This is quite an essential feature. :) |
4u
added a commit
to 4u/react-router
that referenced
this pull request
Nov 19, 2018
* 'v3' of github.com:ReactTraining/react-router: Access <Link>s underlying node via `innerRef` (remix-run#6340) 3.2.1 Update a bunch of other deps. Make switching from master to v3 even easier.
|
@timdorr I'm a little confused on what this means, does that mean that something is missing before this feature is able to go out? I see that the code change was merged to master and the package.json reflects version as 3.2.1, and there was a npm release for 3.2.1 9 months ago - what would it take for v3 to be bumped to 3.2.2 and include this change? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this is essentially a port of #5294 to v3.