Support react 16.6 for react-router v3 #6806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
reviewed
Jun 24, 2019
timdorr
reviewed
Jun 24, 2019
|
Awesome work! I'll try to get this pushed out today. |
|
Thank you 🎉🎉🎉 |
|
Thank you |
|
@timdorr with the fixes for component types does this mean react-router 3 now officially supports react-redux 7.x? |
|
@dlong500 I hope it could. If you encounter any problem, please create an issue. I'll try to fix it if possible. |
|
Yes, I believe it should be good with connected components now. |
|
Thanks @timdorr. I ran into the same issue yesterday, and today I see the fix is out :-) I can confirm, react-router@3.2.2 works with react@16.8 and react-redux@7.1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
#6766
Why
react router v3 supports components as props with format
{ [name]: component }according to this. However, newer react component may also be an objects, so it would make react-router v3 broken.How to fix
Use
isValidElementTypeis distinguish{ [name]: component }and react components forReact.memo,React.forwardRef,React.Fragmentand so on