switch to ubuntu-latest and remove Unity 2019

ReactUnity · Apr 9, 2024 · 869341c · 869341c
1 parent 77814f4
commit 869341c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 10 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -31,12 +31,11 @@ jobs:
       fail-fast: false
       matrix:
         platform:
-          - ubuntu-20.04
+          - ubuntu-latest
         unity:
           - { version: "2021.3.28f1" }
           - { version: "2021.1.28f1" }
           - { version: "2020.3.43f1" }
-          - { version: "2019.4.40f1" }
         suite:
           - {
               name: "Unit Tests",
@@ -117,10 +116,6 @@ jobs:
           echo $(cat tests/Packages/manifest.json | jq '.dependencies["com.reactunity.quickjs"]="file:../../quickjs"') > tests/Packages/manifest.json
           echo $(cat tests/Packages/manifest.json | jq '.dependencies["com.reactunity.clearscript"]="file:../../clearscript"') > tests/Packages/manifest.json
 
-      - name: Install TMP v2
-        if: startsWith(matrix.unity.version, '2019')
-        run: echo $(cat tests/Packages/manifest.json | jq '.dependencies["com.unity.textmeshpro"]="2.1.6"') > tests/Packages/manifest.json
-
       - name: Run Unity Tests
         uses: game-ci/unity-test-runner@v2
         id: testRunner

diff --git a/Runtime/Yoga/YogaNode.cs b/Runtime/Yoga/YogaNode.cs
@@ -414,10 +414,7 @@ public void Clear()
         {
             if (_children != null)
             {
-                while (_children.Count > 0)
-                {
-                    RemoveAt(_children.Count - 1);
-                }
+                RemoveAll();
             }
         }