Rewrite repo in typescript

[robertjcolley]

TODO

• Export all types from index.ts
• Fix component imports
• Rework animation validation in TypeScript
• Remove prop-types dependency
• Remove react-create-class dependency
• Create an example in Bobby's Starter App for each of the documented components
  • Viro360Image
  • Viro360Video
  • Viro3DObject
  • ViroAnimatedImage
  • ViroAmbientLight
  • ViroAnimatedComponent
  • ViroAnimations
  • ViroARImageMarker
  • ViroARObjectMarker
  • ViroARTrackingTargets
  • ViroARPlane
  • ViroARPlaneSelector
  • ViroARScene
  • ViroARSceneNavigator
  • ViroBox
  • ViroButton
  • ViroCamera
  • ViroConstants
  • ViroController
  • ViroDirectionalLight
  • ViroFlexView
  • ViroGeometry
  • ViroLightingEnvironment
  • ViroImage
  • ViroMaterials
  • ViroMaterialVideo
  • ViroNode
  • ViroOmniLight
  • ViroOrbitCamera
  • ViroParticleEmitter
  • ViroPolygon
  • ViroPolyline
  • ViroPortal
  • ViroPortalScene
  • ViroQuad
  • ViroScene
  • ViroSceneNavigator
  • ViroSkyBox
  • ViroSound
  • ViroSoundField
  • ViroSpatialSound
  • ViroSphere
  • ViroSpinner
  • ViroSpotLight
  • ViroText
  • ViroVideo
  • ViroVRSceneNavigator
  • Viro3DSceneNavigator
  • Styles
  • PolarToCartesian
  • IsARSupportedOnDevice

Possible TODO Items

• Create a Scene superclass
• Create a Navigator superclass
• Determine the types of all the events (when an event fires, what is passed?)

Lingering Questions

The following list is things which I was not sure about when I came across them, or were not intuitive types for me to figure out.

Status	Component	Item
	Viro3DObject	What is morphTargets? What does it do?
	Viro3DSceneNavigator	viroAppProps?: any; // TODO: what is the type of this?
	Viro3DSceneNavigator	exitViro: this.exitViro, TODO: this was unused
	Viro3DSceneNavigator	@todo: use Typescript function overloading rather than this inaccurate solution
	Viro3DSceneNavigator	@todo: use Typescript function overloading rather than this inaccurate solution
	Viro3DSceneNavigator	@todo: use Typescript function overloading rather than this inaccurate solution
	ViroButton	// TODO: rather than manually expanding/setting props, we should do {...this.props} which will save us time when adding new properties
	ViroButton	// TODO: This was different than the other onHover callbacks
	ViroScene	// TODO: types for closest
	ViroSceneNavigator	viroAppProps?: any; // TODO: what is the type of this?
	ViroSceneNavigator	exitViro: this.exitViro, TODO: this was unused
	ViroSceneNavigator	@todo: use Typescript function overloading rather than this inaccurate solution
	ViroSceneNavigator	@todo: use Typescript function overloading rather than this inaccurate solution
	ViroSceneNavigator	@todo: use Typescript function overloading rather than this inaccurate solution
	ViroSound	soundSrc = { name: soundSrc }
	ViroSoundField	soundSrc = { name: soundSrc }
	ViroSpatialSound	soundSrc = { name: soundSrc }
	ViroVRSceneNavigator	viroAppProps?: any; // TODO: what is the type of this?
	ViroVRSceneNavigator	exitViro: this.exitViro, TODO: this was unused
	ViroVRSceneNavigator	@todo: use Typescript function overloading rather than this inaccurate solution
	ViroVRSceneNavigator	@todo: use Typescript function overloading rather than this inaccurate solution
	ViroVRSceneNavigator	@todo: use Typescript function overloading rather than this inaccurate solution
	ViroARScene	anchor functions are in a different format than everywhere else
	ViroARSceneNavigator	viroAppProps?: any; // TODO: what is the type of this?
	ViroARSceneNavigator	exitViro: this.exitViro, TODO: this was unused
	ViroVRSceneNavigator	@todo: use Typescript function overloading rather than this inaccurate solution
	ViroVRSceneNavigator	@todo: use Typescript function overloading rather than this inaccurate solution
	ViroVRSceneNavigator	@todo: use Typescript function overloading rather than this inaccurate solution
	ViroARSceneNavigator	Error codes types for screen recording through viro

[robertjcolley]

@doranteseduardo I've considered this complete. I've tested everything in my starter kit, but I think it's ready to go. The issues I've found (#74 and #75) were replicated in my typescript repo and in the latest released version of viro.

There might be more documentation or scripts I need to update - essentially, tsc needs to be run to generate the dist folder before the repo can be uploaded to NPM

[robertjcolley]

• ViroVideo was broken as part of this ViroVideo is not working #75 is not reproducible with the current latest NPM version.

[robertjcolley]

ViroVideo was broken on the ts branch since main hadn't been merged into it 😅 Merging in main and adding the resources folder to dist fixed the issue!

[doranteseduardo]

👍