Removing references to fbjs #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good job! I think that is a good practice to remove dependencies like this. |
adelarsq
approved these changes
Mar 19, 2021
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fbjsis used in two places in order to raiseInvariant Violationerrors.Depending on how the project is interpreted by metro (this seems to happen in RN 0.64.0) it does pick up on the usage of
fbjs, however it isn't a dependency of the project, so bundling fails. (Wasfbjspulled in by RN in previous versions? Unsure. It certainly isn't on 64...)Rather than add a dependency for two lines of code, I've removed the references, and replaced them with the equivalent errors being thrown manually, as the change is tiny.