Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update ios and android builds #137

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions .github/workflows/pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,12 @@ jobs:
- name: set up JDK
uses: actions/setup-java@v3
with:
distribution: 'adopt'
java-version: 11
distribution: "adopt"
java-version: 17

- name: assemble ViroCore
run: |
./gradlew assembleDebug
./gradlew :viroreact:assembleDebug
working-directory: ./android
- name: Upload result ViroCore
uses: actions/upload-artifact@v3.1.2
Expand All @@ -41,13 +41,13 @@ jobs:
uses: actions/checkout@v3.3.0
with:
fetch-depth: 0
- name: Install JDK 11
- name: Install JDK
uses: actions/setup-java@v3
with:
distribution: "adopt"
java-version: 11
java-version: 17
- name: Code checks
run: ./gradlew check
run: ./gradlew :viroreact:check
- name: Archive Lint report
uses: actions/upload-artifact@v3.1.2
if: ${{ always() }}
Expand All @@ -62,8 +62,8 @@ jobs:
strategy:
fail-fast: false
matrix:
xcode: [ '12.5.1', '13.2.1' ]
macOS: [ 'macOS-11' ]
xcode: ["14.2.0", "13.4.1"]
macOS: ["macos-12"]
steps:
- uses: actions/checkout@v3.3.0
- name: Install gpg
Expand All @@ -79,12 +79,12 @@ jobs:
- name: Xcodebuild iOS Renderer (non-static)
run: |
cd ios
xcodebuild \
set -o pipefail && xcodebuild \
-workspace ViroRenderer.xcworkspace \
-scheme ViroKit \
-sdk iphoneos \
-configuration Release \
IPHONEOS_DEPLOYMENT_TARGET=9.0
IPHONEOS_DEPLOYMENT_TARGET=13.0 | xcpretty

- name: Upload iOS Renderer artifact
uses: actions/upload-artifact@v3.1.2
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Release with changelog
on:
push:
tags:
- '*'
- "*"

jobs:
release:
Expand All @@ -17,14 +17,14 @@ jobs:
- name: Install JDK ${{ matrix.java_version }}
uses: actions/setup-java@v3
with:
distribution: 'adopt'
java-version: 11
distribution: "adopt"
java-version: 17

- name: Get the version
id: tagger
uses: jimschubert/query-tag-action@v2
with:
skip-unshallow: 'true'
skip-unshallow: "true"
abbrev: false
commit-ish: HEAD

Expand All @@ -44,7 +44,7 @@ jobs:
uses: malinskiy/action-android/install-sdk@release/0.1.3

- name: Build project
run: ./gradlew assembleRelease
run: ./gradlew :viroreact:assembleRelease
working-directory: ./android

- name: Create Release
Expand All @@ -60,4 +60,4 @@ jobs:
./virocore/build/outputs/aar/virocore-release.aar
./sharedCode/build/outputs/aar/sharedCode-release.aar
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
6 changes: 3 additions & 3 deletions android/build.gradle
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
buildscript {
ext.kotlin_version = '1.6.21'
ext.kotlin_version = '1.8.21'
repositories {
mavenCentral()
google()
}
dependencies {
classpath 'com.android.tools.build:gradle:7.4.2'
classpath 'com.android.tools.build:gradle:8.2.0'
classpath 'com.github.dcendents:android-maven-gradle-plugin:2.1'
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:1.8.21"
}
}

Expand Down
12 changes: 7 additions & 5 deletions android/code-samples/ARBlackPanther/build.gradle
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
apply plugin: 'com.android.library'

android {
compileSdkVersion 31
compileSdkVersion 33
namespace "com.example.virosample.blackPanther"

defaultConfig {
minSdkVersion 24
targetSdkVersion 31
targetSdkVersion 33
testInstrumentationRunner 'androidx.test.runner.AndroidJUnitRunner'
ndkVersion = "25.2.9519653"
ndk {
abiFilters "arm64-v8a", "armeabi-v7a", "x86", "armeabi", "mips"
}
Expand All @@ -31,8 +33,8 @@ android {

dependencies {
implementation fileTree(dir: 'libs', include: ['*.jar'])
implementation 'androidx.appcompat:appcompat:1.3.1'
androidTestImplementation 'androidx.test.espresso:espresso-core:3.4.0'
implementation 'androidx.appcompat:appcompat:1.0.0'
androidTestImplementation 'androidx.test.espresso:espresso-core:3.1.0'
implementation 'androidx.constraintlayout:constraintlayout:2.1.4'
testImplementation 'junit:junit:4.13.2'
api project(':code-samples:gvr_common')
Expand All @@ -43,5 +45,5 @@ dependencies {
codeImplementation (project(path: ':virocore')) {
transitive = false
}
implementation 'com.google.protobuf.nano:protobuf-javanano:3.2.0rc2'
implementation 'com.google.protobuf.nano:protobuf-javanano:3.0.0-alpha-7'
}
12 changes: 7 additions & 5 deletions android/code-samples/ARHelloWorldAndroid/build.gradle
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
apply plugin: 'com.android.library'

android {
compileSdkVersion 31
compileSdkVersion 33
namespace "com.example.virosample.hello"

defaultConfig {
minSdkVersion 24
targetSdkVersion 31
targetSdkVersion 33
testInstrumentationRunner 'androidx.test.runner.AndroidJUnitRunner'
ndkVersion = "25.2.9519653"
ndk {
abiFilters "arm64-v8a", "armeabi-v7a", "x86", "armeabi", "mips"
}
Expand Down Expand Up @@ -35,8 +37,8 @@ android {

dependencies {
implementation fileTree(dir: 'libs', include: ['*.jar'])
implementation 'androidx.appcompat:appcompat:1.3.1'
androidTestImplementation 'androidx.test.espresso:espresso-core:3.4.0'
implementation 'androidx.appcompat:appcompat:1.0.0'
androidTestImplementation 'androidx.test.espresso:espresso-core:3.1.0'
implementation 'androidx.constraintlayout:constraintlayout:2.1.4'
testImplementation 'junit:junit:4.13.2'
api project(':code-samples:gvr_common')
Expand All @@ -47,5 +49,5 @@ dependencies {
codeImplementation (project(path: ':virocore')) {
transitive = false
}
implementation 'com.google.protobuf.nano:protobuf-javanano:3.2.0rc2'
implementation 'com.google.protobuf.nano:protobuf-javanano:3.0.0-alpha-7'
}
16 changes: 9 additions & 7 deletions android/code-samples/ARPlacingObjects/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,14 @@ apply plugin: 'com.android.library'
apply plugin: 'kotlin-android'

android {
compileSdkVersion 31
compileSdkVersion 33
namespace "com.example.virosample.placingObjects"

defaultConfig {
minSdkVersion 24
targetSdkVersion 31
targetSdkVersion 33
testInstrumentationRunner 'androidx.test.runner.AndroidJUnitRunner'
ndkVersion = "25.2.9519653"
ndk {
abiFilters "arm64-v8a", "armeabi-v7a", "x86", "armeabi", "mips"
}
Expand Down Expand Up @@ -42,9 +44,9 @@ android {

dependencies {
implementation fileTree(dir: 'libs', include: ['*.jar'])
implementation 'androidx.appcompat:appcompat:1.3.1'
implementation 'androidx.appcompat:appcompat:1.0.0'
implementation 'com.google.android.material:material:1.6.1'
androidTestImplementation 'androidx.test.espresso:espresso-core:3.4.0'
androidTestImplementation 'androidx.test.espresso:espresso-core:3.1.0'
implementation 'androidx.constraintlayout:constraintlayout:2.1.4'
testImplementation 'junit:junit:4.13.2'
api project(':code-samples:gvr_common')
Expand All @@ -55,7 +57,7 @@ dependencies {
codeImplementation (project(path: ':virocore')) {
transitive = false
}
implementation 'com.google.protobuf.nano:protobuf-javanano:3.2.0rc2'
implementation "androidx.core:core-ktx:1.6.0"
implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:$kotlin_version"
implementation 'com.google.protobuf.nano:protobuf-javanano:3.0.0-alpha-7'
implementation "androidx.core:core-ktx:1.8.0"
implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.8.21"
}
12 changes: 7 additions & 5 deletions android/code-samples/ARRetail/build.gradle
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
apply plugin: 'com.android.library'

android {
compileSdkVersion 31
compileSdkVersion 33
namespace "com.example.virosample.retail"

defaultConfig {
minSdkVersion 24
targetSdkVersion 31
targetSdkVersion 33
testInstrumentationRunner 'androidx.test.runner.AndroidJUnitRunner'
ndkVersion = "25.2.9519653"
ndk {
abiFilters "arm64-v8a", "armeabi-v7a", "x86", "armeabi", "mips"
}
Expand All @@ -31,8 +33,8 @@ android {
dependencies {
implementation fileTree(dir: 'libs', include: ['*.jar'])
implementation 'androidx.recyclerview:recyclerview:1.2.1'
implementation 'androidx.appcompat:appcompat:1.3.1'
androidTestImplementation 'androidx.test.espresso:espresso-core:3.4.0'
implementation 'androidx.appcompat:appcompat:1.0.0'
androidTestImplementation 'androidx.test.espresso:espresso-core:3.1.0'
implementation 'androidx.constraintlayout:constraintlayout:2.1.4'
testImplementation 'junit:junit:4.13.2'
api project(':code-samples:gvr_common')
Expand All @@ -43,5 +45,5 @@ dependencies {
codeImplementation (project(path: ':virocore')) {
transitive = false
}
implementation 'com.google.protobuf.nano:protobuf-javanano:3.2.0rc2'
implementation 'com.google.protobuf.nano:protobuf-javanano:3.0.0-alpha-7'
}
12 changes: 7 additions & 5 deletions android/code-samples/ARTesla/build.gradle
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
apply plugin: 'com.android.library'

android {
compileSdkVersion 31
compileSdkVersion 33
namespace "com.example.virosample.tesla"

defaultConfig {
minSdkVersion 24
targetSdkVersion 31
targetSdkVersion 33
testInstrumentationRunner 'androidx.test.runner.AndroidJUnitRunner'
ndkVersion = "25.2.9519653"
ndk {
abiFilters "arm64-v8a", "armeabi-v7a", "x86", "armeabi", "mips"
}
Expand All @@ -30,8 +32,8 @@ android {

dependencies {
implementation fileTree(dir: 'libs', include: ['*.jar'])
implementation 'androidx.appcompat:appcompat:1.3.1'
androidTestImplementation 'androidx.test.espresso:espresso-core:3.4.0'
implementation 'androidx.appcompat:appcompat:1.0.0'
androidTestImplementation 'androidx.test.espresso:espresso-core:3.1.0'
implementation 'androidx.constraintlayout:constraintlayout:2.1.4'
testImplementation 'junit:junit:4.13.2'
api project(':code-samples:gvr_common')
Expand All @@ -43,5 +45,5 @@ dependencies {
codeApi (project(path: ':virocore')) {
transitive = false
}
implementation 'com.google.protobuf.nano:protobuf-javanano:3.2.0rc2'
implementation 'com.google.protobuf.nano:protobuf-javanano:3.0.0-alpha-7'
}
2 changes: 1 addition & 1 deletion android/code-samples/arcore_client/build.gradle
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
configurations.maybeCreate("default")
artifacts.add("default", file('core-1.26.0.aar'))
artifacts.add("default", file('core-1.41.0.aar'))
Binary file removed android/code-samples/arcore_client/core-1.26.0.aar
Binary file not shown.
Binary file not shown.
2 changes: 1 addition & 1 deletion android/code-samples/gvr_common/build.gradle
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
configurations.maybeCreate("default")
artifacts.add("default", file('sdk-common-1.130.0.aar'))
artifacts.add("default", file('sdk-common-1.180.0.aar'))
Binary file not shown.
Binary file not shown.
Binary file modified android/gradle/wrapper/gradle-wrapper.jar
Binary file not shown.
2 changes: 1 addition & 1 deletion android/gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-7.3.3-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-8.3-all.zip
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
Loading
Loading