-
Notifications
You must be signed in to change notification settings - Fork 21
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix Reaction.get_element_mass() (#609)
The `get_element_mass` method in Reaction iterates through the elements of the reactants and returns the mass of the respective elements. However, it doesn't take into account that when a reaction has two identical reactant (e.g., `OH + OH <=> H2O2`), ARC only stores one instance of the reactant species to avoid running duplicate identical QM jobs. This method was fixed and it uses now the `get_reactants_and_products` method that considers identical reactants/products. A test was added.
- Loading branch information
Showing
2 changed files
with
5 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters