Skip to content

Commit

Permalink
Merge pull request #429 from ReactionMechanismGenerator/scan_fixes
Browse files Browse the repository at this point in the history
Misc. scan fixes
  • Loading branch information
alongd committed Oct 8, 2020
2 parents 2381762 + 0a351c1 commit a2b2f62
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
5 changes: 3 additions & 2 deletions arc/species/species.py
Original file line number Diff line number Diff line change
Expand Up @@ -1076,8 +1076,9 @@ def initialize_directed_rotors(self):
for vals2 in vals1:
for val in vals2:
if val not in all_pivots:
raise SpeciesError('The pivots {0} do not represent a rotor in species {1}. Valid rotors '
'are: {2}'.format(val, self.label, all_pivots))
raise SpeciesError(f'The pivots {val} do not represent a rotor in species {self.label}. '
f'Valid rotor pivots are: {all_pivots}\n\n'
f'Species coordinates:\n{xyz_to_str(self.get_xyz())}')
# Modify self.rotors_dict to remove respective 1D rotors dicts and add ND rotors dicts
rotor_indices_to_del = list()
for key, vals in directed_rotors.items():
Expand Down
2 changes: 1 addition & 1 deletion docs/source/advanced.rst
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,7 @@ an ND scan. Values are nested lists. Each value is a list where the entries are
or lists of pivot lists (e.g., ``[[1, 5], [6, 8]]``), or a mix (e.g., ``[[4, 8], [[6, 9], [3, 4]]``). The requested
directed scan type will be executed separately for each list entry. A list entry that contains only two pivots
will result in a 1D scan, while a list entry with N pivots will consider all of them, and will result in an ND scan
(if ``_diagonal`` is not specified).
(if ``_diagonal`` is not specified). Note that indices are 1-indexed.

ARC will generate geometries using the ``rotor_scan_resolution`` argument in ``settings.py``.

Expand Down

0 comments on commit a2b2f62

Please sign in to comment.