Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default max stepsize for optimization in Gaussian #108

Merged
merged 1 commit into from
Apr 2, 2019
Merged

Conversation

oscarwumit
Copy link
Contributor

As suggested by Duminda, setting MaxStep = 5 in Gaussian gives better TS
result. The default value in G16 is MaxStep = 30 (less rigorious)

@oscarwumit oscarwumit requested a review from alongd March 28, 2019 19:06
@oscarwumit oscarwumit changed the title Set default max size for optimization in Gaussian Set default max stepsize for optimization in Gaussian Mar 28, 2019
@alongd
Copy link
Member

alongd commented Mar 29, 2019

Thanks! Then let's also add it to optfreq and composite job types

As suggested by Duminda, setting MaxStep = 5 in Gaussian gives better TS
result. The default value in G16 is MaxStep = 30 (less rigorious)
@codecov
Copy link

codecov bot commented Mar 29, 2019

Codecov Report

Merging #108 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #108   +/-   ##
=======================================
  Coverage   40.55%   40.55%           
=======================================
  Files          22       22           
  Lines        5265     5265           
  Branches     1373     1373           
=======================================
  Hits         2135     2135           
- Misses       2780     2782    +2     
+ Partials      350      348    -2
Impacted Files Coverage Δ
arc/job/job.py 20.36% <0%> (ø) ⬆️
arc/reaction.py 42.12% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f96500f...58b9831. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 29, 2019

Codecov Report

Merging #108 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #108   +/-   ##
=======================================
  Coverage   40.55%   40.55%           
=======================================
  Files          22       22           
  Lines        5265     5265           
  Branches     1373     1373           
=======================================
  Hits         2135     2135           
  Misses       2780     2780           
  Partials      350      350
Impacted Files Coverage Δ
arc/job/job.py 20.36% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f96500f...58b9831. Read the comment docs.

@oscarwumit
Copy link
Contributor Author

I added maxstep=5 to all related gaussian TS job types. @alongd

@alongd
Copy link
Member

alongd commented Apr 2, 2019

Thanks!!

@alongd alongd merged commit e4c85a6 into master Apr 2, 2019
@alongd alongd deleted the maxstep branch April 2, 2019 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants