Minor: Change YAML FullLoader to Loader
#223
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #223 +/- ##
=======================================
Coverage 46.13% 46.13%
=======================================
Files 30 30
Lines 8868 8868
Branches 2598 2598
=======================================
Hits 4091 4091
+ Misses 4134 4126 -8
- Partials 643 651 +8
Continue to review full report at Codecov.
|
In PyYaml version 5.x above, the FullLoader is not backward compatible with previous PyYaml versions. This results ARC crash in some restart jobs. The `Loader` function, instead, is backward compatible.
oscarwumit
force-pushed
the
yaml_read_fix
branch
from
07885b6
to
8cdcff5
Compare
oscarwumit
changed the title
FullLoader to Loader
|
@oscarwumit, could you upload a minimal YAML file that crashes on master? We should make a test out of it on this branch |
alongd
changed the title
FullLoader to LoaderFullLoader to Loader
|
I prefer to keep the version 5.x, if possible, see https://github.com/yaml/pyyaml/wiki/PyYAML-yaml.load(input)-Deprecation |
This was referenced Jan 15, 2020
amarkpayne
pushed a commit
to amarkpayne/ARC
that referenced
this pull request
Jan 15, 2020
Convert negative frequencies troubleshooted to a list when dumping a species as a dictionary, see ReactionMechanismGenerator#223 and ReactionMechanismGenerator#279
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PyYaml version 5.x above, the
FullLoaderis not backward compatible with previous PyYaml versions. This results in ARC crash in some restart jobs. TheLoaderfunction, instead, is backward compatible.-- legacy comments
PyYaml version 3.12 works well with the current ARC codebase. New versions of PyYaml leads to restart issues.
When I restart an ARC job, it crashed because PyYaml complains that
"yaml.constructor.ConstructorError: while constructing a Python instance
expected a class, but found <class 'builtin_function_or_method'>"
After traceback the code, I find PyYaml crashed because of the following code in ARC
yaml.load(stream=f, Loader=yaml.FullLoader)
This seems to be a common PyYaml issue, especially for new versions:
facebookresearch/Detectron#840
Take advice online, I changed the PyYaml version to 3.12. Because in this version, FullLoader is not available, I changed it to Loader. Now we have in ARC
pyyaml = 3.12
yaml.load(stream=f, Loader=yaml.Loader)
After these changes, my restart job works fine :-)