Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified the 1,2_NH3_elimination root group #350

Merged
merged 2 commits into from
Aug 29, 2019
Merged

Conversation

alongd
Copy link
Member

@alongd alongd commented Aug 5, 2019

*3 N cannot have 0 lone pairs, since it looses a lone pair in the recipe.

This fix prohibits species such as

<Molecule "[NH-][NH2+]NN">
1  *3 N u0 p0 c+1 {2,S} {4,S} {5,S} {6,S}
2  *2 N u0 p1 c0 {1,S} {3,S} {7,S}
3  *1 N u0 p1 c0 {2,S} {8,S} {9,S}
4     N u0 p2 c-1 {1,S} {10,S}
5     H u0 p0 c0 {1,S}
6     H u0 p0 c0 {1,S}
7  *4 H u0 p0 c0 {2,S}
8     H u0 p0 c0 {3,S}
9     H u0 p0 c0 {3,S}
10    H u0 p0 c0 {4,S}

from reacting in 1,2_NH3_elimination.

Edit: Also added a minor unrelated commit to update the structure of HON

Copy link
Contributor

@mjohnson541 mjohnson541 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine. I'm happy to approve once we get the tests fixed.

@alongd
Copy link
Member Author

alongd commented Aug 28, 2019

The test fails due to the ndTorsion tearDownClass:

  File "/home/travis/build/ReactionMechanismGenerator/RMG-Py/rmgpy/statmech/ndTorsionsTest.py", line 81, in tearDownClass
    os.remove(os.path.join(os.path.dirname(cls.path),'r0','IOfiles','r0.pes'))
OSError: [Errno 2] No such file or directory: '/home/travis/build/ReactionMechanismGenerator/RMG-Py/arkane/data/CH2CHOOH/r0/IOfiles/r0.pes'

Will that be that fixed as part of the py3 branch, or in a later stage?

@mliu49
Copy link
Contributor

mliu49 commented Aug 28, 2019

It has been fixed on the Py3 branch. We could/should consider setting up q2dtor for RMG-database travis as well.

*3 N cannot have 0 lone pairs, since it looses a lone pair in the recipe
It is a singlet (unless explicitly otherwise noted)
@alongd
Copy link
Member Author

alongd commented Aug 29, 2019

@mjohnson541, this PR should be good to go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants