-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coverage dependence of kinetics #462
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mazeau
force-pushed
the
coverage_dependence
branch
from
April 20, 2021 18:20
7f9e095
to
c81583c
Compare
mazeau
force-pushed
the
coverage_dependence
branch
2 times, most recently
from
May 5, 2021 18:15
363e2d3
to
72ee0f7
Compare
mazeau
force-pushed
the
coverage_dependence
branch
2 times, most recently
from
May 21, 2021 14:40
fc80fa5
to
8a392ba
Compare
davidfarinajr
approved these changes
Jun 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
rwest
force-pushed
the
coverage_dependence
branch
2 times, most recently
from
July 1, 2021 03:28
0c285bf
to
5abfd21
Compare
mazeau
force-pushed
the
coverage_dependence
branch
from
July 1, 2021 19:03
7b3a421
to
a1cff17
Compare
rwest
force-pushed
the
coverage_dependence
branch
2 times, most recently
from
July 8, 2021 15:53
a506e26
to
6764f6b
Compare
rwest
force-pushed
the
coverage_dependence
branch
from
July 13, 2021 04:08
6764f6b
to
73d4a6f
Compare
This is the order used by Chemkin, Cantera, and I suggest RMG.
…icity of reaction
…ted. These are now a, m, E everywhere
rwest
force-pushed
the
coverage_dependence
branch
from
July 22, 2021 21:04
73d4a6f
to
610325f
Compare
Should also be in the _adjusted one
rwest
force-pushed
the
coverage_dependence
branch
from
July 23, 2021 02:26
610325f
to
faa56e4
Compare
rwest
added a commit
to ReactionMechanismGenerator/RMG-Py
that referenced
this pull request
Jul 23, 2021
Adding in coverage dependent effects to surface kinetics. Goes with RMG-database Pull Request ReactionMechanismGenerator/RMG-database#462
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a twin PR that goes with ReactionMechanismGenerator/RMG-Py#2090 to add in coverage dependence kinetics to surface reactions