Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage dependence of kinetics #462

Merged
merged 11 commits into from Jul 23, 2021
Merged

Coverage dependence of kinetics #462

merged 11 commits into from Jul 23, 2021

Conversation

mazeau
Copy link
Contributor

@mazeau mazeau commented Mar 29, 2021

This is a twin PR that goes with ReactionMechanismGenerator/RMG-Py#2090 to add in coverage dependence kinetics to surface reactions

@mazeau mazeau requested a review from ChrisBNEU March 29, 2021 19:03
@mazeau mazeau force-pushed the coverage_dependence branch 2 times, most recently from 363e2d3 to 72ee0f7 Compare May 5, 2021 18:15
@mazeau mazeau force-pushed the coverage_dependence branch 2 times, most recently from fc80fa5 to 8a392ba Compare May 21, 2021 14:40
Copy link
Contributor

@davidfarinajr davidfarinajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@rwest rwest force-pushed the coverage_dependence branch 2 times, most recently from 0c285bf to 5abfd21 Compare July 1, 2021 03:28
@rwest rwest force-pushed the coverage_dependence branch 2 times, most recently from a506e26 to 6764f6b Compare July 8, 2021 15:53
Should also be in the _adjusted one
@rwest rwest merged commit ef2790b into master Jul 23, 2021
@rwest rwest deleted the coverage_dependence branch July 23, 2021 02:27
rwest added a commit to ReactionMechanismGenerator/RMG-Py that referenced this pull request Jul 23, 2021
Adding in coverage dependent effects to surface kinetics.
Goes with RMG-database Pull Request
ReactionMechanismGenerator/RMG-database#462
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants