Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling four party reactions #193

Merged
merged 3 commits into from
May 2, 2022
Merged

Enabling four party reactions #193

merged 3 commits into from
May 2, 2022

Conversation

hwpang
Copy link
Contributor

@hwpang hwpang commented Apr 28, 2022

Expanding the code to handle four party reactions encountered during analyzing the n-heptane combustion model by Curren et al.

@hwpang
Copy link
Contributor Author

hwpang commented Apr 28, 2022

@xiaoruiDong This is the four party branch I mentioned the other day. If you need a version that works for the mechanism that contains 5 party elementary reactions, you may want to start from here.

@hwpang
Copy link
Contributor Author

hwpang commented Apr 29, 2022

New push enable addreactionratecontributionsforwardreverse for four party reactions

@codecov
Copy link

codecov bot commented Apr 30, 2022

Codecov Report

Merging #193 (a51c178) into main (6a96ad6) will decrease coverage by 3.51%.
The diff coverage is 22.57%.

@@            Coverage Diff             @@
##             main     #193      +/-   ##
==========================================
- Coverage   52.30%   48.78%   -3.52%     
==========================================
  Files          29       29              
  Lines        5894     6354     +460     
==========================================
+ Hits         3083     3100      +17     
- Misses       2811     3254     +443     
Impacted Files Coverage Δ
src/PhaseState.jl 76.61% <0.00%> (-1.56%) ⬇️
src/Simulation.jl 30.66% <0.00%> (-0.90%) ⬇️
src/Reactor.jl 47.13% <19.78%> (-28.65%) ⬇️
src/EdgeAnalysis.jl 51.08% <33.33%> (ø)
src/Domain.jl 58.21% <35.60%> (-2.07%) ⬇️
src/Phase.jl 92.18% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Collaborator

@mjohnson541 mjohnson541 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good. Is this ready to merge?

@hwpang
Copy link
Contributor Author

hwpang commented May 2, 2022

@mjohnson541 Yes this is ready to merge.

@mjohnson541 mjohnson541 merged commit 7d534a9 into main May 2, 2022
@mjohnson541 mjohnson541 deleted the four_party branch May 2, 2022 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants