Convert Dict{Any,Any} to Dict{Symbol,Float64} for pyrms compatibility + formatting #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #212 +/- ##
==========================================
- Coverage 49.83% 49.81% -0.03%
==========================================
Files 31 31
Lines 7900 7904 +4
==========================================
Hits 3937 3937
- Misses 3963 3967 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mjohnson541
reviewed
May 13, 2023
src/ThreadedSensitivities.jl
Outdated
| # Convert Dict{Any,Any} to Dict{Symbol, Float64} | ||
| # Needed for pyrms compatability | ||
| # Python string gets converted to String and runs into expected Symbol, got a value of type String error | ||
| if odekwargs isa Dict{Any,Any} |
There was a problem hiding this comment.
- I don't think these kwargs are all symbols mapped to floats so if someone tries to turn on an option that isn't a float I think this will crash
- Can we instead do this the julian way and write a Dict{Any,Any} specific method that just converts the dictionary to Dict{Symbol,Any} and then calls the main method (which I think would need made specific to Dict{Symbol,T})?
There was a problem hiding this comment.
Good call, I fixed it. I remove the Float64() and the type of the new dictionary should be inferred automatically.
There was a problem hiding this comment.
I tried using convert to convert Dict{Any,Any} to Dict{Symbol,Any}, but it doesn't work.
ERROR: MethodError: Cannot `convert` an object of type String to an object of type Symbol
Closest candidates are:
convert(::Type{T}, ::T) where T at Base.jl:61
Symbol(::String) at boot.jl:489
Symbol(::AbstractString) at strings/basic.jl:228
There was a problem hiding this comment.
Oh wait I misunderstood what you meant. I will fix it now
mjohnson541
reviewed
May 13, 2023
allow nonfloat64 value Julian style Allow different typing for odekwargs and senskwargs
|
@mjohnson541 Squashed the commits related to dictionary typing! |
mjohnson541
approved these changes
May 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for pyrms compatability, see ReactionMechanismGenerator/pyrms#6.
Python string gets converted to String and runs into "expected Symbol, got a value of type String" error.
I tried the trick mentioned in JuliaPy/pyjulia#156, but when the symbol is contained in a dictionary, it still gets converted to a String during python to Julia conversion.