Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new domain, remove unused function, and fix rop function dispatch #230

Merged
merged 14 commits into from
Feb 18, 2024

Conversation

hwpang
Copy link
Contributor

@hwpang hwpang commented Aug 8, 2023

  • I added a new domain ConstantTLiqFilmDomain whose volume expands as the film grows. Its volume changes based on the mass of the film domain, where dV/dt = dm/dt / rho / (1 - epsilon) * epsilon, where rho is the density of the solid, and epsilon is the porosity of the film (vol frac of liquid in film)
  • I removed an unused function as film growth reactions are treated as interface now
  • I added "mass" as a column in the rop matrix and changes to address the issue Fragment array functions in Simulation.jl are overwriting other helper functions #219.

@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Attention: 74 lines in your changes are missing coverage. Please review.

Comparison is base (a313530) 49.65% compared to head (eb5202c) 48.93%.

Files Patch % Lines
src/Simulation.jl 6.55% 57 Missing ⚠️
src/Interface.jl 89.94% 17 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #230      +/-   ##
==========================================
- Coverage   49.65%   48.93%   -0.73%     
==========================================
  Files          31       31              
  Lines        8146     8301     +155     
==========================================
+ Hits         4045     4062      +17     
- Misses       4101     4239     +138     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mjohnson541 mjohnson541 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The simulation test is failing, but I've given comments on the changes.

src/Interface.jl Outdated Show resolved Hide resolved
src/Simulation.jl Show resolved Hide resolved
src/TestReactors.jl Outdated Show resolved Hide resolved
@hwpang
Copy link
Contributor Author

hwpang commented Jan 23, 2024

Change log:

  • Rebased with main
  • Split the function to two separate functions, one returns ropmat as normally would, and the other returns ropmat and massropvec.

Copy link
Collaborator

@mjohnson541 mjohnson541 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good. One quick question.

src/Simulation.jl Show resolved Hide resolved
mjohnson541
mjohnson541 previously approved these changes Feb 17, 2024
Copy link
Collaborator

@mjohnson541 mjohnson541 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mjohnson541 mjohnson541 merged commit 0cd6ac6 into ReactionMechanismGenerator:main Feb 18, 2024
3 of 4 checks passed
@hwpang hwpang deleted the fix_fragment_2 branch March 29, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants