fix init and add install function #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think all we need to do is to remove |
hwpang
reviewed
May 14, 2023
| from julia.api import Julia | ||
| jl = Julia(compiled_modules=False) | ||
| from julia import Pkg | ||
| Pkg.add("ReactionMechanismSimulator") |
There was a problem hiding this comment.
Can you change this to
Pkg.add(PackageSpec(name="ReactionMechanismSimulator",rev="main"))
There was a problem hiding this comment.
We discussed offline and think it's better to have more frequent release of RMS and point the user to a specific version. Although I think Pkg.add("ReactionMechanismSimulator") points to a 0.3.4 but not the GitHub release 0.4.0.
hwpang
reviewed
May 23, 2023
pyrms/__init__.py
Outdated
| import os | ||
| import subprocess | ||
|
|
||
| script_dir = os.path.dirname(os.path.realpath(__file__)) |
There was a problem hiding this comment.
I don't think this is used anywhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.