internal isEqual is broken

[acthp]

From the debugger:

isEqual({samples:['a'],order:[1,2]}, {samples:['a'],order:[3,4]})
true

contrasting with underscore:

_.isEqual({samples:['a'],order:[1,2]}, {samples:['a'],order:[3,4]})
false

[acthp]

I suspect the problem is line 223 of rx.js. It looks like this used to do a forEach on the property names, using a callback to return the recursive equality results. Only now it's a for..in, and the return on line 223 exits deepEquals after checking only the first property.

Also, line 232 below this also looks broken in the same way. It looks very much like a forEach -> for..in conversion. unfortunately, I can't find a commit where this happened.

[mattpodwysocki]

Will investigate

[mattpodwysocki]

Fixed as per your request. The following tests will now pass/fail:

isEqual({samples:['a'],order:[1,2]}, {samples:['a'],order:[3,4]})
// => false
isEqual({samples:['a'],order:[1,2]}, {samples:['a'],order:[1,2]})
// => true