Skip to content
This repository has been archived by the owner on Apr 20, 2018. It is now read-only.

Rx.Scheduler.timeout should prefer setImmediate to nextTick #344

Closed
antonycourtney opened this issue Oct 27, 2014 · 3 comments
Closed

Rx.Scheduler.timeout should prefer setImmediate to nextTick #344

antonycourtney opened this issue Oct 27, 2014 · 3 comments

Comments

@antonycourtney
Copy link

Using Rx.Observable.range(start,count,Rx.Scheduler.timeout) with even a modest sized count causes node.js (0.10.32) to crash with a stack overflow. Before crashing node emits a warning indicating that a Recursive process.nextTick was detected and setImmediate should be used in preference to nextTick.
Rx.Scheduler.timeout docs indicate that the intention is to prefer setImmediate on modern versions of node.js but the scheduler source appears to try using nextTick before trying setImmediate.
See this Twitter thread for some additional detail:
https://twitter.com/antonycourtney/status/526024870593691648

mattpodwysocki added a commit that referenced this issue Oct 27, 2014
@mattpodwysocki
Copy link
Member

@antonycourtney closing due to fix and tested locally with 90,000 items

@antonycourtney
Copy link
Author

Great, thank you!

On Mon Oct 27 2014 at 9:58:31 AM Matthew Podwysocki <
notifications@github.com> wrote:

Closed #344 #344.


Reply to this email directly or view it on GitHub
#344 (comment).

@L8D
Copy link
Contributor

L8D commented Oct 28, 2014

@mattpodwysocki why 90,000?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants