Skip to content
This repository has been archived by the owner on Apr 20, 2018. It is now read-only.

Include Observable.prototype.shareReplay in all/allcompat/binding dists #196

Closed

Conversation

theefer
Copy link

@theefer theefer commented Jul 6, 2014

I believe it's omitted from these dist packages by mistake, since the shareReplay documentation lists them?

@mattpodwysocki
Copy link
Member

Removed shareReplay for now since it doesn't mean much as compared to the others per this commit: 41ed965. May reintroduce later.

@theefer
Copy link
Author

theefer commented Jul 9, 2014

Is there any alternative way, using currently exposed primitives, to share a ReplaySubject with all subscribers? I'm trying to prevent multiple subscriptions from causing re-evaluation of the (expensive) upstream operations on the stream, if that makes any sense.

So far I've ended up copying the shareReplay implementation in my code as it was the only way I found to achieve this.

@mattpodwysocki
Copy link
Member

Closing as per commit bf0c2f7 Used wrong issue number. Woops! Will be back in next version 2.2.28

mattpodwysocki added a commit that referenced this pull request Jul 9, 2014
@theefer
Copy link
Author

theefer commented Jul 9, 2014

Awesome, thanks!

@theefer theefer deleted the sc-dist-sharereplay branch July 9, 2014 20:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants