Merge Store and FeedbackLoop API. Rename it to Loop.
#7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergdort
reviewed
May 13, 2020
| public init( | ||
| initial: State, | ||
| reducer: @escaping (inout State, Event) -> Void, | ||
| feedbacks: [Loop<State, Event>.Feedback] |
There was a problem hiding this comment.
Should we just remove old feedback and have Feedback<State, Event>, I find it quite annoying to have API
static func whenSomething() -> Loop<State, Event>. Feedback vs
static func whenSomething() -> Feedback<State, Event>
¯_(ツ)_/¯
There was a problem hiding this comment.
I'd prefer to leave the gradual migration option on the table.
There was a problem hiding this comment.
Alternatively, we can rename the old feedback to something else, so manual migration is required.
There was a problem hiding this comment.
@sergdort lets do that in a separate PR, no?
sergdort
approved these changes
May 13, 2020
|
|
|
@sergdort misconfiguration 🤦 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges
StoreandFeedbackLoopinto one API.API renames
FeedbackLoopandStoreis renamed toLoop.Store.view(value:event:)is renamed toLoop.scoped(to:event:).FeedbackLoop.init(initial:reduce:feedbacks:)is renamed toLoop.init(initial:reducer:feedbacks:).Removed API
FeedbackLoop.start()andFeedbackLoop.stop()are now unavailable.Store.stateis now unavailable. It is replaced byLoop.context, which is a producer yieldingContext<S, E>.Implementation
Loopdoes type erasure by inheritance internally, so that it can be the currency type for both root loops (global stores) & their scoped views (local derived stores).This also hides stuff like
start()andstop()from the public API, that were intended forSignalProducer.feedbackLoop.