Fix filter operation
#2367
Merged
Fix filter operation
#2367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -228,8 +228,10 @@ extension SignalType { | |||
| public func filter(predicate: T -> Bool) -> Signal<T, E> { | |||
| return Signal { observer in | |||
| return self.observe { event in | |||
| if case let .Next(value) = event where predicate(value) { | |||
| sendNext(observer, value) | |||
| if case let .Next(value) = event { | |||
There was a problem hiding this comment.
Huh, wasn't the previous implementation equivalent? 😰
There was a problem hiding this comment.
Oh, duh, that was going to the else branch!
|
Thanks a lot! I imagine the tests caught this though, right? (Even though we're not running them yet, see #2351). |
|
Tests first crash in |
|
Makes sense! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug snuck in with #2354 causing
filterto forward events when the predicate was false. This brings back some nesting to fix that.