use #import, not @import #2524
Merged
use #import, not @import #2524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As far as I can tell, there is no way to enable module support in a project that uses *any* Objective-C++. This means that importing the ReactiveCocoa headers -- even from a pure Objective-C file -- will result in an error on this line. Since it's the only use of @import in the codebase, it seems nice from a consistency standpoint as well.
|
This is 100% equivalent as it will get automatically converted to a module |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell, there is no way to enable module support in a project that uses any Objective-C++. This means that importing the ReactiveCocoa headers -- even from a pure Objective-C file -- will result in an error on this line.
Since it's the only use of
@importin the codebase, it seems nice from a consistency standpoint as well.