Changed toRACSignal from free function to protocol extension #2544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a leftover from the `RAC 3 -> RAC 4` (`Swift 1.2 -> Swift 2.0`) migration.
NachoSoto
force-pushed
the
to-rac-signal-extension
branch
from
465d2cc
to
686232d
Compare
|
👍 |
neilpa
added a commit
that referenced
this pull request
Nov 10, 2015
Changed toRACSignal from free function to protocol extension
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a leftover from the
RAC 3 -> RAC 4(Swift 1.2 -> Swift 2.0) migration.Note that this is a breaking change, but luckily we're in time before the
4.0release.Given that a lot of it is indentation changes, I recommend reviewing it ignoring white spaces.