Associative lift operators to fix synchronous sampleOn #2571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nalProducer) The docs read "If `sampler` fires before a value has been observed on `self`, nothing happens.". However, in this case the sampler "fires" synchronously upon subscription. Thus, I don't think this is the expected behavior.
The differences here are nuanced and only matter for some operators and even then, only when the producers are both synchronous. Lets not expose this complexity in the public API for now.
Completely 👍 |
|
Awesome Great job! |
NachoSoto
added a commit
that referenced
this pull request
Nov 25, 2015
Associative lift operators to fix synchronous sampleOn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided to keep
liftLeftandliftRightprivate for now. I don't think this is a complexity we should expose in the API given that these only matter for some operators and only when both producers are synchronous.