Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skipUntil operator #2576

Merged
merged 4 commits into from Nov 30, 2015
Merged

Add skipUntil operator #2576

merged 4 commits into from Nov 30, 2015

Conversation

cesteban
Copy link
Contributor

Add skipUntil operator, which will skip all values from the signal until a trigger sends .Next or .Completed. From that point all values from the signal will be emitted normally.

Any feedback is highly appreciated.

Fixes #2575.

@@ -1016,6 +1016,27 @@ extension SignalType {
return disposable
}
}

/// Does not forward any values from `self` until `trigger` sends a Next or
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sends a Next or Completed event.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, sorry.

@NachoSoto
Copy link
Member

This looks good! The failing test is unrelated. I opened an issue to fix that flaky test.

@NachoSoto
Copy link
Member

:shipit:

@NachoSoto NachoSoto self-assigned this Nov 29, 2015
NachoSoto added a commit that referenced this pull request Nov 30, 2015
@NachoSoto NachoSoto merged commit e26e334 into ReactiveCocoa:master Nov 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants