Completely refactored NSObject+RACKVOWrapper #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactoring clears up (IMO) the vocabulary of the implementation. What were known as "targets" are now "observers," and observed objects are now known as "targets." (The switch is undoubtably confusing, but it should be clearer going forward.) This also removes the unnecessary distinction between target/observer trampolines, and improves thread safety.
This way, tests can use __weak references to verify memory management.
dannygreg
pushed a commit
that referenced
this pull request
Aug 8, 2012
Completely refactored NSObject+RACKVOWrapper
| [self rac_customObservableDealloc]; | ||
| [trampolines makeObjectsPerformSelector:@selector(stopObserving)]; | ||
|
|
||
| [self performSelector:@selector(rac_customDealloc)]; |
There was a problem hiding this comment.
wat? Why not just call it directly?
There was a problem hiding this comment.
Ah, shit. This was left over from trying a bunch of different things when all of this wasn't working.
andersio
pushed a commit
that referenced
this pull request
Sep 22, 2016
Fixed Retain cycles in UIKit extensions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes: