Break retain cycle with Action.unsafeCocoaAction #2910
Conversation
| public var unsafeCocoaAction: CocoaAction { | ||
| return associatedObject(self, key: &unsafeCocoaActionKey, initial: { host in |
There was a problem hiding this comment.
private var unsafeCocoaActionKey should be removed as well.
| @@ -176,12 +177,15 @@ class ActionSpec: QuickSpec { | |||
| let result = action.apply(0).first() | |||
| expect(result?.value) == 1 | |||
| expect(values).toEventually(equal([ true, false, true ])) | |||
|
|
|||
| _ = cocoaAction | |||
There was a problem hiding this comment.
Just curious, what is this assignation here for ?
There was a problem hiding this comment.
That's to keep cocoaAction from deallocating before the end of the test—because when it deallocates, the producer will complete.
|
👍 |
|
This kind of change should not be hidden behind a simple "fixed retain cycle" in the release notes. While this code works fine in RAC 4.1, it compiles and fails silently in RAC 4.2: someButton.addTarget(someAction.unsafeCocoaAction, action: CocoaAction.selector)I feel like this change kind of defeats the purpose of having |
|
Sorry for the inconvenience! Let's move this discussion to #2983. I'll try to comment there soon, but it may to happen this week because of WWDC. |
Fixes #2233.