Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add SignalProducer variadic init with values #2928

Conversation

larryonoff
Copy link
Contributor

No description provided.

@RuiAAPeres
Copy link
Member

👍

@RuiAAPeres RuiAAPeres merged commit 65457a0 into ReactiveCocoa:master May 23, 2016
@larryonoff larryonoff deleted the feature/signal-producer-extend-init branch May 23, 2016 20:30
@ikesyo
Copy link
Member

ikesyo commented Jun 2, 2016

We have found that this is a bit problematic for type inference. See https://github.com/Carthage/Carthage/pull/1329/files#r65486309 for the details.

EDITED: I'm sorry, this would not be true. This may be because flatMap overloads from #2885.

@larryonoff
Copy link
Contributor Author

@ikesyo I spent some time on analysis of possible solutions, but haven't find any solutions except reverting this PR and making v4.2.1 until it isn't too late.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants