You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
mdiep
merged 2 commits into
ReactiveCocoa:master
from
tomj:playground_build_steps_typos_formattingMay 24, 2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed on #2916 let's add instructions for how to build the project and run the playground. Another teeny commit to nix a couple of typos and formatting issues.
The reason will be displayed to describe this comment to others. Learn more.
Oh, now I understand the Problem in #2916. I was confused because the Playground instructions in the Readme already state that you need to run script/bootstrap.
Maybe you could also update the instructions in the Readme
The reason will be displayed to describe this comment to others. Learn more.
@iv-mexx yeah I didn't quite understand it myself at first either. 3066cf2 brings the playground instructions in the main README up to date with the new playground steps
Adding context to this, when I started creating the playground, I took a lot of inspiration from what was done in the RxSwift playground. Since it look and felt good I went with that approach.
@RuiAAPeres I think it's perfectly reasonable to keep it similar to the RxSwift playground (at least for now until there's a better format proposed). And looks like we can remove the Build Result-Mac line as pointed out by @ikesyo
- Tell users to grab the project dependencies before
trying to run the playgrounds
- Update the README playground instructions to
match those in the playgrounds themselves
- Fix a typo and update the formatting in the
playground instructions
As you wish - e3c3f8d. @RuiAAPeres fwiw just then I took a look and if I delete my derived data folder and then rebuild onlyReactiveCocoa-Mac then my Build/Products/Debug contains ReactiveCocoa and Result frameworks. Either way I don't think it hurts to have this here as it's instructive as much as anything else (and the way 3rd party frameworks are handled in playgrounds seems to be quite fragile at the best of times so being over cautious could be prudent).
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed on #2916 let's add instructions for how to build the project and run the playground. Another teeny commit to nix a couple of typos and formatting issues.