Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Travis] Use Debug configuration for carthage build to reduce the build time #3166

Closed
wants to merge 1 commit into from

Conversation

ikesyo
Copy link
Member

@ikesyo ikesyo commented Sep 3, 2016

I'm not sure if this should be merged or not.

@mdiep
Copy link
Contributor

mdiep commented Sep 4, 2016

It looks like it saves some time. So I guess so? I don't anticipate that the release build will ever fail if the debug build works. 😕

@NachoSoto
Copy link
Member

Nope! I don't think we should. I think we're better off paying the time cost, for the benefit of knowing that RAC works in a production environment. There are many things that are different:

  • Swift optimizations.
  • Code that may only be compiled under debug.
  • Whole module optimization, which has been known to make the Swift compiler crash altogether.

So I'm 👎 on this one.

@ikesyo
Copy link
Member Author

ikesyo commented Sep 5, 2016

Nope! I don't think we should. I think we're better off paying the time cost, for the benefit of knowing that RAC works in a production environment. There are many things that are different:

For the purposes, instead of building with Release configuration through Carthage, we should build/run the tests with xcodebuild ... -configuration Release ENABLE_TESTABILITY=YES I think.

@ikesyo
Copy link
Member Author

ikesyo commented Sep 5, 2016

we should build/run the tests with xcodebuild ... -configuration Release ENABLE_TESTABILITY=YES I think.

Oh, that is already done:

@NachoSoto
Copy link
Member

Example of something we wouldn't have found with this: #2751

@ikesyo
Copy link
Member Author

ikesyo commented Sep 5, 2016

Anyway, if we attach a prebuilt binary of carthage build --no-skip-current to a GitHub release within Travis in future, we cannot use --configuration Debug for the artifact. So I'm closing this.

@ikesyo ikesyo closed this Sep 5, 2016
@ikesyo
Copy link
Member Author

ikesyo commented Sep 5, 2016

@ikesyo ikesyo deleted the travis-carthage-debug-configuration branch September 5, 2016 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants