Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add UITextField set textColor Binding Target #3410

Merged
merged 2 commits into from
Mar 12, 2017
Merged

add UITextField set textColor Binding Target #3410

merged 2 commits into from
Mar 12, 2017

Conversation

c12dd
Copy link
Contributor

@c12dd c12dd commented Mar 11, 2017

No description provided.

mdiep
mdiep requested changes Mar 11, 2017
View reviewed changes
Copy link
Contributor

@mdiep mdiep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind adding a test for this as well? 🙏

(You can basically copy-and-paste one of the other UITextField tests, so it should be very easy.)

@c12dd
Copy link
Contributor Author

c12dd commented Mar 12, 2017

OK

@mdiep
Copy link
Contributor

mdiep commented Mar 12, 2017

Thanks for the PR!

@mdiep mdiep merged commit a475495 into ReactiveCocoa:master Mar 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdiep mdiep mdiep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@c12dd @mdiep