Refactoring for Swift 3.1. #3428
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That test doesn't want to pass on this branch. 😕 |
NachoSoto
reviewed
Apr 2, 2017
| @@ -8,6 +8,8 @@ import CoreGraphics | |||
|
|
|||
| class InterceptingSpec: QuickSpec { | |||
| override func spec() { | |||
| ForwardInvocationTestObject.swizzleForTesting() | |||
There was a problem hiding this comment.
I'd put this in beforeAll. If these tests aren't gonna run there's no point in calling this function.
There was a problem hiding this comment.
beforeAll is not available in Quick IIRC.
There was a problem hiding this comment.
Oh I think its beforeSpec now.
| @@ -7,6 +7,8 @@ import enum Result.NoError | |||
|
|
|||
| class UIButtonSpec: QuickSpec { | |||
| override func spec() { | |||
| UIControl.swizzleForTesting() | |||
NachoSoto
reviewed
Apr 5, 2017
| @@ -824,13 +828,23 @@ class InterceptingSpec: QuickSpec { | |||
| } | |||
| } | |||
|
|
|||
| extension DispatchQueue { | |||
NachoSoto
approved these changes
Apr 5, 2017
|
#3446 seems to have a better approach. Closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.