Add podspec ✔️ #11
Merged
Add podspec ✔️ #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Pitometsu
commented
Oct 1, 2016
Pitometsu
commented
- Fix few unused lint errors.
|
According to #10 Please, check and merge to Also, there's some minor fixes to avoid lint warnings. |
Closed
Pitometsu
force-pushed
the
CocoaPods
branch
5 times, most recently
from
4444200
to
43f9b60
Compare
$ pod spec lint
-> ReactiveObjC (1.0.0)
- WARN | xcodebuild: ReactiveObjC/ReactiveObjC/RACCompoundDisposable.m:85:12: warning: unused variable 'result' [-Wunused-variable]
- WARN | xcodebuild: ReactiveObjC/ReactiveObjC/RACCompoundDisposable.m:132:12: warning: unused variable 'result' [-Wunused-variable]
- WARN | xcodebuild: ReactiveObjC/ReactiveObjC/RACSerialDisposable.m:63:12: warning: unused variable 'result' [-Wunused-variable]
- WARN | xcodebuild: ReactiveObjC/ReactiveObjC/RACSerialDisposable.m:79:12: warning: unused variable 'result' [-Wunused-variable]
Analyzed 1 podspec.
[!] The spec did not pass validation, due to 4 warnings (but you can use `--allow-warnings` to ignore them). |
- Fix few unused lint errors.
mdiep
requested changes
Oct 1, 2016
| s.documentation_url = "https://github.com/ReactiveCocoa/ReactiveObjC/"\ | ||
| "tree/master/Documentation#readme" | ||
|
|
||
| s.author = { "Josh Abernathy" => "josh@github.com" } |
There was a problem hiding this comment.
Can you set the author to be ReactiveCocoa to match what ReactiveSwift does.
There was a problem hiding this comment.
| s.requires_arc = true | ||
|
|
||
| s.frameworks = "Foundation" | ||
| s.dependency "Result", "~> 2.0" |
There was a problem hiding this comment.
ReactiveObjC doesn't depend on Result.
There was a problem hiding this comment.
|
@mdiep done, please, check c302fbe#diff-354f30a63fb0907d4ad57269548329e3R58. |
- Add pod lint to travis script.
mdiep
approved these changes
Oct 4, 2016
|
Thanks! |
|
I've released 1.0.1 with the build warning fixes and push the podspec to CocoaPods trunk. 🚀 |
byohay
pushed a commit
to byohay/ReactiveObjC
that referenced
this pull request
Jan 6, 2018
ReactiveObjC: upgrade to Xcode 9.
stuartofmine
pushed a commit
to stuartofmine/ReactiveObjC_2023
that referenced
this pull request
Oct 18, 2023
Add podspec ✔️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.