Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bufferWithTime return value #66

Merged
merged 1 commit into from Dec 21, 2016
Merged

Fix bufferWithTime return value #66

merged 1 commit into from Dec 21, 2016

Conversation

bobspryn
Copy link
Contributor

Unless buffer's functionality has changed, it should be sending along RACTuples of ValueType, not ValueType itself.

@bobspryn
Fix bufferWithTime return value
983268b 
Unless buffer's functionality has changed, it should be sending along `RACTuple`s of `ValueType`, not `ValueType` itself.
@bobspryn bobspryn mentioned this pull request Dec 21, 2016
Closed
erichoracek
erichoracek approved these changes Dec 21, 2016
View reviewed changes
Copy link
Contributor

@erichoracek erichoracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me—likely that this was just an oversight during the lightweight generics migration.

@bobspryn
Copy link
Contributor Author

Yeah that was my guess.

@mdiep
Copy link
Contributor

mdiep commented Dec 21, 2016

Thanks for the PR!

@mdiep mdiep merged commit 1d0307e into ReactiveCocoa:master Dec 21, 2016
stuartofmine pushed a commit to stuartofmine/ReactiveObjC_2023 that referenced this pull request Oct 18, 2023
@mdiep
Merge pull request ReactiveCocoa#66 from sprynmr/patch-1
111524e 
Fix bufferWithTime return value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdiep mdiep mdiep approved these changes

@erichoracek erichoracek erichoracek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bobspryn @mdiep @erichoracek