New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor refactoring in `Signal`. #113

Closed

andersio wants to merge 3 commits into master from minor-refactor-signal

Member

andersio commented Nov 24, 2016 •

edited

Drop NSLocks to be in line with Atomic. (it is slower than pthread mutexes on Darwin due to dynamic dispatching)
Break the SignalState to reduce unnecessary retains and releases caused by the signal self reference.

andersio added 2 commits

November 24, 2016 01:43


          Drop NSLocks in Signal.

b192598


          Avoid copying the internal signal reference.

e5510f7

andersio force-pushed the minor-refactor-signal branch from 2a0c876 to e5510f7 Compare

November 24, 2016 01:16

andersio mentioned this pull request

Synthetic benchmark on a few pending PRs combined. #122

Closed


          Fixed a signal leak.

ecef702

andersio closed this

andersio deleted the minor-refactor-signal branch

November 25, 2016 08:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment