notifications as Signal.
#64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NachoSoto
requested changes
Oct 13, 2016
| var observedObject: AnyObject? = NSObject() | ||
| let producer = center.reactive.notifications(forName: nil, object: observedObject) | ||
| observedObject = nil | ||
| it("should be freed if it is not reachable and no observers is attached") { |
There was a problem hiding this comment.
Shouldn'tno observers be singular?
There was a problem hiding this comment.
"observers" is plural.
You could also say "no observer is attached".
| @@ -24,10 +24,10 @@ class FoundationExtensionsSpec: QuickSpec { | |||
| let center = NotificationCenter.default | |||
|
|
|||
| it("should send notifications on the producer") { | |||
| let producer = center.reactive.notifications(forName: .racFirst) | |||
|
|
||
| disposable.dispose() | ||
| } | ||
| expect(signal).toNot(beNil()) |
|
|
||
| disposable.dispose() |
There was a problem hiding this comment.
We need another test similar to this one to verify that the signal is not freed if there are other observers.
andersio
force-pushed
the
notifications-signal
branch
from
4622af2
to
4929a20
Compare
andersio
force-pushed
the
notifications-signal
branch
from
4929a20
to
d11bca4
Compare
19 tasks
NachoSoto
reviewed
Oct 18, 2016
| } | ||
|
|
||
| it("should be not freed if it still has one or more active observers") { |
|
🎉 |
NachoSoto
approved these changes
Oct 18, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signalstarts right away, so the weak capturing ofobserverwas removed.