Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conditionally import swift ui #26

Merged
merged 1 commit into from
Oct 13, 2020
Merged

Conditionally import swift ui #26

merged 1 commit into from
Oct 13, 2020

Conversation

AndreiVidrasco
Copy link
Contributor

No description provided.

@mluisbrown
Copy link
Collaborator

Could you also incorporate the changes from 7630087 into this PR?

Then I think we might have a working solution for conditionally excluding both Combine and SwiftUI.

@AndreiVidrasco AndreiVidrasco mentioned this pull request Oct 12, 2020
Closed
@AndreiVidrasco
Copy link
Contributor Author

It's pointing to your branch, not to master. Merge it there and then you can create a new PR with all changes to go to master

@mluisbrown mluisbrown merged commit 90c6c8b into ReactiveCocoa:michael/if-can-import-combine Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mluisbrown mluisbrown mluisbrown approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AndreiVidrasco @mluisbrown