Publish pekko based ReactiveMongo binaries #1245

SamTheisens · 2023-08-06T14:36:26Z

Pull Request Checklist

Have you read How to write the perfect pull request?
Have you read through the contributor guidelines?
Have you added tests for any changed functionality?

Fixes

Fixes #1244

Purpose

Create a pekko based ReactiveMongo distribution for those who want to adopt Pekko.

Background Context

Implementation details

Introduce neutral aliases for Akka actor dependencies to minimize duplication
Pulls in akka or pekko dependencies based on a build parameter

Features

Publishes pekko variants of all modules
Adds pekko based permutations to integration test matrix
Does not build scala 3 version for pekko yet, because Pekko needs Scala 3.3.0 or higher

Some integration tests are failing intermittently with timeouts, but it doesn't seem related to the changes.

Related PR on documentation repo ReactiveMongo/reactivemongo-site#316

To minimize duplication: - Introduce neutral aliases for Akka actor dependencies - Pull in akka or pekko dependencies based on a build parameter - Publish pekko variants of all modules - Add pekko based permutations to integration test matrix

project/Common.scala

cchantep

Thx for the contributions. Few comments.

actors-akka/src/main/scala/reactivemongo/actors/actor/package.scala

actors-akka/src/main/scala/reactivemongo/actors/util/package.scala

actors-pekko/src/main/scala/reactivemongo/actors/util/package.scala

build.sbt

driver/src/main/scala/api/AsyncDriver.scala

driver/src/main/scala/api/Failover.scala

project/Dependencies.scala

project/Driver.scala

actors-akka/src/test/scala/reactivemongo/actors/testkit/package.scala

build.sbt

project/Publish.scala

build.sbt

project/Common.scala

Fristi · 2023-09-14T12:32:19Z

Heya, what's blocking this at the moment? Is there a way I could help?

cchantep · 2023-09-14T21:12:08Z

Heya, what's blocking this at the moment? Is there a way I could help?

#1245 (comment)

SamTheisens · 2023-09-15T01:59:23Z

Heya, what's blocking this at the moment? Is there a way I could help?

#1245 (comment)

The compiler crash is the biggest blocker I suppose. I've submitted a crash report scala/scala3#18555.
Unfortunately I haven't been able to construct a minimal reproduction example. That would undoubtedly increase the chances of it being addressed.
@cchantep do you perhaps have some ideas about what might be the root cause?

Fristi · 2023-09-15T07:12:56Z

Would releasing ReactiveMongo with Pekko support and Scala 3.3 support in a seperate PR / version an idea once this is resolved? I would like to move forward with my Akka migration and I'm on a Scala 2.x code base :)

I think most users are using Scala 2.x anyway

mdedetrich · 2023-09-15T07:26:28Z

The compiler crash is the biggest blocker I suppose. I've submitted a crash report lampepfl/dotty#18555. Unfortunately I haven't been able to construct a minimal reproduction example. That would undoubtedly increase the chances of it being addressed. @cchantep do you perhaps have some ideas about what might be the root cause?

Some compiler crashes were resolved in 3.3.1, are you still having issues swith this version?

SamTheisens · 2023-09-15T07:30:19Z

The compiler crash is the biggest blocker I suppose. I've submitted a crash report lampepfl/dotty#18555. Unfortunately I haven't been able to construct a minimal reproduction example. That would undoubtedly increase the chances of it being addressed. @cchantep do you perhaps have some ideas about what might be the root cause?

Some compiler crashes were resolved in 3.3.1, are you still having issues swith this version?

I've tried 3.3.1. Unfortunately the issue is still there.

mdedetrich · 2023-09-15T07:31:23Z

I've tried 3.3.1. Unfortunately the issue is still there.

Okay thanks, I am cloning the PR as we speak to see if I can diagnose/minimize the issue

SamTheisens · 2023-09-15T14:19:22Z

@cchantep I've found that this change SamTheisens@8cac59b#diff-c6447c7894adc9cfe97724d939b60a87a2aca260563123fefb254d6cf6e73097R17-R18 makes the project compile. Would that be an acceptable solution?

mdedetrich · 2023-09-15T14:24:46Z

@cchantep I've found that this change SamTheisens@8cac59b#diff-c6447c7894adc9cfe97724d939b60a87a2aca260563123fefb254d6cf6e73097R17-R18 makes the project compile. Would that be an acceptable solution?

Nice find!

If this is not acceptable, what can be done is you can split out

type Writer[A]
type Reader[A]

into its own trait, and have the scala-2 implementation be

type Writer[A]
type Reader[A]

and scala-3 be

type Writer[A] = BSONDocumentWriter[A]
type Reader[A] = BSONDocumentReader[A]

that way the change is isolated just to Scala 3 artifact.

cchantep · 2023-09-15T14:30:54Z

@cchantep I've found that this change SamTheisens@8cac59b#diff-c6447c7894adc9cfe97724d939b60a87a2aca260563123fefb254d6cf6e73097R17-R18 makes the project compile. Would that be an acceptable solution?

Nice find!

If this is not acceptable, what can be done is you can split out
type Writer[A]
type Reader[A]
into its own trait, and have the scala-2 implementation be
type Writer[A]
type Reader[A]
and scala-3 be
type Writer[A] = BSONDocumentWriter[A]
type Reader[A] = BSONDocumentReader[A]
that way the change is isolated just to Scala 3 artifact.

The API won't be changed, for temporary bug on the Scala 3 compiler.
Otherwise then we will have to manage to revert back, with version compatibility complexity.

mdedetrich · 2023-09-15T14:38:14Z

Otherwise then we will have to manage to revert back, with version compatibility complexity.

I don't think this change has an impact regarding MiMa because its a type alias, so if correct you can revert it without any implications (its basically adding a default type parameter which would always be overridden anyways).

cchantep · 2023-09-15T14:54:18Z

Otherwise then we will have to manage to revert back, with version compatibility complexity.

I don't think this change has an impact regarding MiMa because its a type alias, so if correct you can revert it without any implications (its basically adding a default type parameter which would always be overridden anyways).

Type member are part of the API.
So that's indeed a breaking change.

mdedetrich · 2023-09-15T15:10:17Z

Type member are part of the API.
So that's indeed a breaking change.

I understand they are part of the API and it is changing the API, however the term "breaking" has a very explicit technical meaning (talking about bincompat/MiMa here) and I don't think its applicable here.

Undefined type members (which is what type Writer[A]/type Reader[A] are) have to be reified at some point, what type Writer[A] = BSONDocumentWriter[A] is doing is its putting a default value on that type parameter but this shouldn't effect any code that implements this API.

Even if you were to hypothetically add this change and then remove it later, it also should not effect any code implementing this API because because you dealing with an un-implemented type member which at some point has to be evaluated to a proper type.

In fact if you check the issue that caused the change at scala/scala3#16373, at least from what I understand the reason why Scala 3 is complaining in this case is exactly because it can't find a full implementation of that type after erasure (and its not like it can scan all possible implementations of that type outside of the project).

Ill try and do some hacking on the Scala 3 compiler to see if I can avoid this check if we are dealing with undefined type members, but the reason I am bringing this up is that there is a chance that you may need to provide a default value for these undefined type members if a fix doesn't get accepted (I am mentioning this because not every change in the Scala 3 compiler is considered a regression, sometimes if the improvement is warranted then you have to deal with it).

Obviously have to see what Scala 3 team says

cchantep · 2023-09-15T21:04:33Z

I understand they are part of the API and it is changing the API, however the term "breaking" has a very explicit technical meaning (talking about bincompat/MiMa here) and I don't think its applicable here

Please stop arguing, that's not constructive.

From a maintainer point of view, it breaks the API, for an external issue that (should) being fix.

project/Common.scala

because pekko requires scala >= 3.3, which can only be used if and when scala/scala3#18555 is addressed branch:

SamTheisens · 2023-10-02T05:48:56Z

The scala community is moving away from Akka. Scala 2.13 libraries can be used in Scala 3 projects and it's It's not certain when and if scala/scala3#18555 will be addressed.
Therefore I think it would be great if this PR could be merged and Scala 3 binaries added later in a follow up. As suggested here #1244 (comment). Do you think that would be possible?

project/Common.scala

cchantep · 2023-10-07T13:26:37Z

Thanks

SamTheisens · 2023-10-08T02:50:06Z

Thanks

Thanks for merging @cchantep. Out of curiosity: are you planning to make a new 1.1.0-RC12 release with these changes?

Fristi · 2023-10-09T07:34:46Z

I would be keen to see a release with these artifacts been published, a 1.1.0-RC12 would be awesome :)

SamTheisens · 2023-10-09T10:29:44Z

I would be keen to see a release with these artifacts been published, a 1.1.0-RC12 would be awesome :)

@Fristi It's published to sonatype already:

<dependency>
  <groupId>org.reactivemongo</groupId>
  <artifactId>reactivemongo-actors-pekko_2.13</artifactId>
  <version>1.1.0-RC12-SNAPSHOT</version>
</dependency>

Extract akka/pekko dependencies to project

72b1a98

To minimize duplication: - Introduce neutral aliases for Akka actor dependencies - Pull in akka or pekko dependencies based on a build parameter - Publish pekko variants of all modules - Add pekko based permutations to integration test matrix

SamTheisens force-pushed the feature/pekko-support branch from 4285936 to 72b1a98 Compare August 7, 2023 03:18

SamTheisens mentioned this pull request Aug 7, 2023

pekko-stream support ReactiveMongo/ReactiveMongo-Streaming#322

Merged

4 tasks

pjfanning reviewed Aug 7, 2023

View reviewed changes

project/Common.scala Show resolved Hide resolved

SamTheisens force-pushed the feature/pekko-support branch 2 times, most recently from 67ed756 to 72b1a98 Compare August 7, 2023 10:44

cchantep requested changes Aug 7, 2023

View reviewed changes

SamTheisens requested a review from cchantep August 7, 2023 14:31

Scalafix and formatting fixes

f4b1814

SamTheisens force-pushed the feature/pekko-support branch from 87d3301 to f4b1814 Compare August 7, 2023 14:33

cchantep approved these changes Aug 8, 2023

View reviewed changes

actors-akka/src/test/scala/reactivemongo/actors/testkit/package.scala Outdated Show resolved Hide resolved

build.sbt Outdated Show resolved Hide resolved

project/Publish.scala Outdated Show resolved Hide resolved

SamTheisens added 3 commits August 8, 2023 22:56

Convert to interpolated string

0533709

Remove unnecessary import alias

6ce1498

Add ReactiveMongo as prefix to actor modules

be05bbd

cchantep reviewed Aug 9, 2023

View reviewed changes

build.sbt Outdated Show resolved Hide resolved

project/Common.scala Show resolved Hide resolved

Remove unused imports

6e239cb

pjfanning mentioned this pull request Aug 19, 2023

support mongodb for scala3 apache/pekko-connectors#150

Open

ReactiveMongo locked as too heated and limited conversation to collaborators Sep 15, 2023

cchantep reviewed Sep 20, 2023

View reviewed changes

project/Common.scala Show resolved Hide resolved

Exclude scala 3 from pekko build

51e65f4

because pekko requires scala >= 3.3, which can only be used if and when scala/scala3#18555 is addressed branch:

SamTheisens force-pushed the feature/pekko-support branch 3 times, most recently from d0050ed to 51e65f4 Compare September 26, 2023 14:04

Merge branch 'ReactiveMongo:master' into feature/pekko-support

6a130c3

SamTheisens force-pushed the feature/pekko-support branch from aab8ad1 to 6a130c3 Compare September 30, 2023 13:51

ReactiveMongo unlocked this conversation Oct 1, 2023

cchantep reviewed Oct 4, 2023

View reviewed changes

project/Common.scala Outdated Show resolved Hide resolved

cchantep added 2 commits October 4, 2023 22:50

Update project/Common.scala

22a7833

Update Common.scala

3bb6200

cchantep merged commit a506201 into ReactiveMongo:master Oct 7, 2023
1 check passed

ReactiveMongo locked as resolved and limited conversation to collaborators Oct 9, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Publish pekko based ReactiveMongo binaries #1245

Publish pekko based ReactiveMongo binaries #1245

SamTheisens commented Aug 6, 2023 •

edited

Loading

cchantep left a comment

Fristi commented Sep 14, 2023

cchantep commented Sep 14, 2023

SamTheisens commented Sep 15, 2023

Fristi commented Sep 15, 2023 •

edited

Loading

mdedetrich commented Sep 15, 2023

SamTheisens commented Sep 15, 2023

mdedetrich commented Sep 15, 2023

SamTheisens commented Sep 15, 2023

mdedetrich commented Sep 15, 2023 •

edited

Loading

cchantep commented Sep 15, 2023

mdedetrich commented Sep 15, 2023 •

edited

Loading

cchantep commented Sep 15, 2023

mdedetrich commented Sep 15, 2023

cchantep commented Sep 15, 2023 •

edited

Loading

SamTheisens commented Oct 2, 2023

cchantep commented Oct 7, 2023

SamTheisens commented Oct 8, 2023

Fristi commented Oct 9, 2023

SamTheisens commented Oct 9, 2023 •

edited

Loading

Publish pekko based ReactiveMongo binaries #1245

Publish pekko based ReactiveMongo binaries #1245

Conversation

SamTheisens commented Aug 6, 2023 • edited Loading

Pull Request Checklist

Fixes

Purpose

Background Context

cchantep left a comment

Choose a reason for hiding this comment

Fristi commented Sep 14, 2023

cchantep commented Sep 14, 2023

SamTheisens commented Sep 15, 2023

Fristi commented Sep 15, 2023 • edited Loading

mdedetrich commented Sep 15, 2023

SamTheisens commented Sep 15, 2023

mdedetrich commented Sep 15, 2023

SamTheisens commented Sep 15, 2023

mdedetrich commented Sep 15, 2023 • edited Loading

cchantep commented Sep 15, 2023

mdedetrich commented Sep 15, 2023 • edited Loading

cchantep commented Sep 15, 2023

mdedetrich commented Sep 15, 2023

cchantep commented Sep 15, 2023 • edited Loading

SamTheisens commented Oct 2, 2023

cchantep commented Oct 7, 2023

SamTheisens commented Oct 8, 2023

Fristi commented Oct 9, 2023

SamTheisens commented Oct 9, 2023 • edited Loading

SamTheisens commented Aug 6, 2023 •

edited

Loading

Fristi commented Sep 15, 2023 •

edited

Loading

mdedetrich commented Sep 15, 2023 •

edited

Loading

mdedetrich commented Sep 15, 2023 •

edited

Loading

cchantep commented Sep 15, 2023 •

edited

Loading

SamTheisens commented Oct 9, 2023 •

edited

Loading