fix spelling, add tailing slash #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanniktech
approved these changes
Jan 12, 2018
JakeWharton
requested changes
Jan 12, 2018
rxandroid/build.gradle
Outdated
| @@ -115,8 +115,8 @@ bintray { | |||
| licenses = ['Apache-2.0'] | |||
| labels = ['rxjava', 'reactivex'] | |||
| websiteUrl = 'https://github.com/ReactiveX/RxAndroid/' | |||
| issueTrackerUrl = 'https://github.com/ReactiveX/RxAndroid/issues' | |||
| vcsUrl = 'https://github.com/ReactiveX/RxAndroid.git' | |||
| issueTrackerUrl = 'https://github.com/ReactiveX/RxAndroid/issues/' | |||
There was a problem hiding this comment.
I don't see any reason to change this. GitHub doesn't include it in their URLs.
There was a problem hiding this comment.
I thought the ~/issue would be a folder, so I thought it would be redirected to ~/issues/.
I thought the other url was the same. But I tried it, but it was not.
So, I'll fix and push again. Thanks
rxandroid/build.gradle
Outdated
| issueTrackerUrl = 'https://github.com/ReactiveX/RxAndroid/issues' | ||
| vcsUrl = 'https://github.com/ReactiveX/RxAndroid.git' | ||
| issueTrackerUrl = 'https://github.com/ReactiveX/RxAndroid/issues/' | ||
| vcsUrl = 'https://github.com/ReactiveX/RxAndroid.git/' |
There was a problem hiding this comment.
don't see any reason to change this. GitHub doesn't include it in their clone URLs.
rxandroid/build.gradle
Outdated
| @@ -84,7 +84,7 @@ install { | |||
| // | |||
| // Based on NebulaOJOPublishingPlugin (from nebula-bintray-plugin) | |||
| artifactory { | |||
| contextUrl = 'https://oss.jfrog.org' | |||
| contextUrl = 'https://oss.jfrog.org/' | |||
There was a problem hiding this comment.
Again, what reason is there to add this? Seems like pointless churn.
CHANGES.md
Outdated
| @@ -25,9 +25,9 @@ The sections below contain the changes since 2.0.0-RC1. | |||
|
|
|||
| RxAndroid 2.0 has been rewritten from scratch to support RxJava 2.0. | |||
|
|
|||
| The library still offers the same APIs: a scheduler and stream cancelation callback that know about | |||
| The library still offers the same APIs: a scheduler and stream cancellation callback that know about | |||
There was a problem hiding this comment.
Both of these spellings are considered correct, for what it's worth.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix spelling
add trailing slash