Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make find_package(rxcpp CONFIG) work through exporting TARGETS #509

Merged
merged 2 commits into from
Aug 18, 2019
Merged

make find_package(rxcpp CONFIG) work through exporting TARGETS #509

merged 2 commits into from
Aug 18, 2019

Conversation

Exctues
Copy link
Contributor

@Exctues Exctues commented Aug 3, 2019

Signed-off-by: exctues alexnamecode@gmail.com

The idea is to allow Config mode(not only Module) in find_package function.
So, now in order to import rxcpp in the other project what you need to do is:

  1. install rxcpp by "make install"
  2. add find_package(rxcpp CONFIG) into CMakeLists.txt

Signed-off-by: exctues <alexnamecode@gmail.com>
@kirkshoop
Copy link
Member

Nice! Would you please add this to the Readme?

Signed-off-by: exctues <alexnamecode@gmail.com>
@Exctues
Copy link
Contributor Author

Exctues commented Aug 7, 2019

Nice! Would you please add this to the Readme?

Sure. Can you check it?

@kirkshoop kirkshoop merged commit 1fadd7e into ReactiveX:master Aug 18, 2019
@kirkshoop
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants