Fix: https://github.com/ReactiveX/RxGo/issues/234

[v-zubko]

Maybe Window function also should be addressed?

[coveralls]

Pull Request Test Coverage Report for Build 764

• 85 of 114 (74.56%) changed or added relevant lines in 1 file are covered.
• 14 unchanged lines in 2 files lost coverage.
• Overall coverage increased (+0.07%) to 84.199%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
observable_operator.go	85	114	74.56%

Files with Coverage Reduction	New Missed Lines	%
observable.go	1	86.47%
observable_operator.go	13	81.6%

Totals
Change from base Build 758:	0.07%
Covered Lines:	2787
Relevant Lines:	3310

---

💛 - Coveralls

[teivah]

Thanks @v-zubko but the tests are failing.

[v-zubko]

Yup, I saw :) @teivah Does this change go in a right way? Or you would do it different? Do I have to update BufferWithTimeOrCount, WindowWithTime and WindowWithTimeOrCount?

[teivah]

Yup, I saw :) @teivah Does this change go in a right way? Or you would do it different? Do I have to update BufferWithTimeOrCount, WindowWithTime and WindowWithTimeOrCount?

Yes, I like the approach. Let's forget about this causalityDuration for the time being and keep things simple.
If you want to tackle the others as well, yes please :)

[teivah]

@v-zubko Some tests are failing like Test_Observable_WindowWithTime

[v-zubko]

Where are they failing? CI is green :)

[teivah]

On my local env:

        	Error Trace:	assert.go:225
        	            				observable_operator_test.go:1665
        	Error:      	Not equal: 
        	            	expected: []interface {}{5, 6, 7}
        	            	actual  : []interface {}{5, 6, 7, 8}

Try repeating them. Also, some tests like Test_Observable_BufferWithTime are taking 9 seconds.

[v-zubko]

9 seconds is expected. Cause of delays.

[v-zubko]

BTW are you sure that you've got latest version? Cause I see another expected values:

Assert(ctx, t, JustItem((<-observe).V), HasItems(1, 2))
Assert(ctx, t, JustItem((<-observe).V), HasItems(3, 4, 5))
Assert(ctx, t, JustItem((<-observe).V), HasItems(6, 7, 8))

[teivah]

BTW are you sure that you've got latest version? Cause I see another expected values:

Assert(ctx, t, JustItem((<-observe).V), HasItems(1, 2))
Assert(ctx, t, JustItem((<-observe).V), HasItems(3, 4, 5))
Assert(ctx, t, JustItem((<-observe).V), HasItems(6, 7, 8))

Nope, check at the files changed on this PR.

It's still:

Assert(ctx, t, (<-observe).V.(Observable), HasItems(0, 1))
Assert(ctx, t, (<-observe).V.(Observable), HasItems(2, 3, 4))
Assert(ctx, t, (<-observe).V.(Observable), HasItems(5, 6, 7))

Moreover, we can't keep a unit test to executes in 9 seconds.

[teivah]

No longer active